Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GenevaExporter] Remove extra table name mapping validation #1109

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Mar 27, 2023

Relates to #1105

[Note: I plan to make a hotfix branch for 1.4 once this goes in.]

Changes

  • Removes the extra validation added in 1.4 which was breaking for some folks.

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes

@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Mar 27, 2023
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Merging #1109 (fe14f4a) into main (b908088) will decrease coverage by 0.09%.
The diff coverage is 97.05%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
- Coverage   71.33%   71.24%   -0.09%     
==========================================
  Files         222      222              
  Lines        8396     8367      -29     
==========================================
- Hits         5989     5961      -28     
+ Misses       2407     2406       -1     
Impacted Files Coverage Δ
...ns.AWSXRay/Resources/Models/AWSEBSMetadataModel.cs 100.00% <ø> (ø)
...AWSXRay/Resources/Models/AWSEKSClusterDataModel.cs 100.00% <ø> (ø)
...Telemetry.Exporter.Geneva/GenevaExporterOptions.cs 89.74% <ø> (+3.37%) ⬆️
...ry.Exporter.Geneva/Internal/TableNameSerializer.cs 98.93% <ø> (+2.70%) ⬆️
...ons/Internal/OpenTelemetryExtensionsEventSource.cs 45.45% <40.00%> (-4.55%) ⬇️
...nsions.AWSXRay/Resources/AWSECSResourceDetector.cs 83.69% <92.30%> (-1.09%) ⬇️
...ensions.AWSXRay/Resources/ResourceDetectorUtils.cs 100.00% <100.00%> (ø)
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 80.56% <100.00%> (-1.19%) ⬇️
...ons/Internal/ActivityEventAttachingLogProcessor.cs 94.11% <100.00%> (+0.78%) ⬆️
...nsions/Logs/LogToActivityEventConversionOptions.cs 100.00% <100.00%> (ø)

@CodeBlanch CodeBlanch merged commit e4b49d2 into open-telemetry:main Mar 27, 2023
@CodeBlanch CodeBlanch deleted the genevaexporter-tablename-validation-fix branch March 27, 2023 23:03
CodeBlanch added a commit to CodeBlanch/opentelemetry-dotnet-contrib that referenced this pull request Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants