Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in 1.4: TableNameMapping doesn't allow table name to start with lowercase character #1105

Closed
1 task
dpk83 opened this issue Mar 24, 2023 · 3 comments
Assignees
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva

Comments

@dpk83
Copy link

dpk83 commented Mar 24, 2023

Issue with OpenTelemetry.Exporter.Geneva

OpenTelemetry.Exporter.Geneva 1.4.0

Is this a feature request or a bug?

  • Feature Request
  • [x ] Bug

What is the expected behavior?
Geneva supports table names that starts with lowercase characters, so a table name that starts with lowercase character should work.

What do you expect to see?
When I pass a table name that starts with lowercase characters in TableNameMapping i.e. myTable, then it should work.

What is the actual behavior?
Exporter throws when table name provided in TableNameMapping starts with lowercase character.

This is a breaking change because the logs can not be sent to existing tables which were being used prior to 1.4 release. Moving logs to new table breaks the user experience

options.TableNameMapping = new Dictionary<string, string>
{
     ["Example.DefaultService"] = "myTableName"
};

This doesn't work and throws. Was working with 1.3 release.

Additional Context

Add any other context about the feature request here.

@dpk83 dpk83 added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Mar 24, 2023
@cijothomas
Copy link
Member

@utpilla Please take a look. Thanks.

@CodeBlanch CodeBlanch changed the title Breaking change in 1.4: TableNameMapping doesn't allow table name to start with uppercase character Breaking change in 1.4: TableNameMapping doesn't allow table name to start with lowercase character Mar 27, 2023
@CodeBlanch CodeBlanch self-assigned this Mar 27, 2023
@CodeBlanch
Copy link
Member

@dpk83 FYI GenevaExporter v1.4.1 available on NuGet now with a fix for this.

@dpk83
Copy link
Author

dpk83 commented Mar 29, 2023

Great. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

No branches or pull requests

3 participants