Update the latest OTel stable version to 1.4.0 #1042
Conversation
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
github-actions
bot
requested review from
cijothomas,
CodeBlanch,
mic-max,
reyang and
Yun-Ting
github-actions
bot
assigned hananiel, rajkumar-rangaraj, SergeyKanzhelev and vishweshbankwar
src/OpenTelemetry.Instrumentation.AspNet.TelemetryHttpModule/CHANGELOG.md
Outdated
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.StackExchangeRedis/CHANGELOG.md
Outdated
Show resolved
Hide resolved
| @@ -17,6 +17,7 @@ | |||
| <PackageReference Include="OpenTelemetry.Api" Version="$(OpenTelemetryCoreLatestVersion)" /> | |||
| <PackageReference Include="StackExchange.Redis" Version="$(StackExchangeRedisPkgVer)" /> | |||
| <PackageReference Include="Microsoft.Extensions.Options" Version="$(MicrosoftExtensionsOptionsPkgVer)" /> | |||
| <PackageReference Include="System.Reflection.Emit.Lightweight" Version="$(SystemReflectionEmitLightweightPkgVer)" Condition="'$(TargetFramework)' != 'net6.0'" /> | |||
There was a problem hiding this comment.
It will be great to have infor about new direct reference in changelog.
| @@ -31,11 +31,12 @@ | |||
| <MicrosoftOwinPkgVer>[4.2.2,5.0)</MicrosoftOwinPkgVer> | |||
| <MicrosoftPublicApiAnalyzersPkgVer>[3.3.3]</MicrosoftPublicApiAnalyzersPkgVer> | |||
| <MicrosoftSourceLinkGitHubPkgVer>[1.1.1,2.0)</MicrosoftSourceLinkGitHubPkgVer> | |||
| <OpenTelemetryCoreLatestVersion>[1.3.2,2.0)</OpenTelemetryCoreLatestVersion> | |||
| <OpenTelemetryCoreLatestVersion>[1.4.0,2.0)</OpenTelemetryCoreLatestVersion> | |||
| <OpenTelemetryCoreLatestPrereleaseVersion>[1.4.0-rc.4,2.0)</OpenTelemetryCoreLatestPrereleaseVersion> | |||
There was a problem hiding this comment.
Please change all OpenTelemetryCoreLatestPrereleaseVersion to OpenTelemetryCoreLatestVersion
Or at least change this line to 1.4.0 instead of RC
There was a problem hiding this comment.
I was thinking about this. It sounds weird to have OpenTelemetryCoreLatestPrereleaseVersion point to a non-prerelease version 😀
We could change it 1.4.0 for now and then update it to 1.5.0-alpha.1 when it's out.
@cijothomas Thoughts?
There was a problem hiding this comment.
We could change it 1.4.0 for now and then update it to 1.5.0-alpha.1 when it's out.
This sounds good.
|
Compilation issues can be handled by 68eeab7 |
|
@utpilla, @cijothomas - please check #1038 - it was created before you have made 1.4.0 release. If you prefer move forward with this PR, please close mine. |
I did not realize that there were 2 PRs for the same! Lets proceed with this now, to unblock other works depending on 1.4 in this repo. Lets sync on slack channel before mas-otel-version bump, to make sure no duplicate efforts occur. @utpilla @Kielek |
|
These changes were covered in #1038. |
Changes