-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Geneva.Metrics] Add option to disable name validation #1006
Merged
CodeBlanch
merged 9 commits into
open-telemetry:main
from
CodeBlanch:geneva-metricnamevalidation
Feb 28, 2023
Merged
[Geneva.Metrics] Add option to disable name validation #1006
CodeBlanch
merged 9 commits into
open-telemetry:main
from
CodeBlanch:geneva-metricnamevalidation
Feb 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
cijothomas,
mic-max,
reyang,
utpilla and
Yun-Ting
February 15, 2023 20:47
dpk83
approved these changes
Feb 15, 2023
cijothomas
reviewed
Feb 16, 2023
src/OpenTelemetry.Exporter.Geneva/Metrics/GenevaMetricExporterOptions.cs
Outdated
Show resolved
Hide resolved
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
@CodeBlanch reminder so you don't miss this one :) |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1006 +/- ##
==========================================
+ Coverage 69.40% 69.87% +0.46%
==========================================
Files 202 202
Lines 7668 7678 +10
==========================================
+ Hits 5322 5365 +43
+ Misses 2346 2313 -33
|
github-actions
bot
assigned cijothomas, CodeBlanch, mic-max, reyang, utpilla and Yun-Ting
Feb 27, 2023
reyang
approved these changes
Feb 27, 2023
utpilla
added
the
comp:exporter.geneva
Things related to OpenTelemetry.Exporter.Geneva
label
Feb 27, 2023
utpilla
reviewed
Feb 27, 2023
src/OpenTelemetry.Exporter.Geneva/Internal/ConnectionStringBuilder.cs
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Feb 27, 2023
utpilla
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Note: This requires an OTel SDK with 4187]
Changes
DisableMetricNameValidation
connection string flag which will set the validation regex to.*
Considerations
/cc @dpk83
TODOs
CHANGELOG.md
updated for non-trivial changes