Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Geneva.Metrics] Add option to disable name validation #1006

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Feb 15, 2023

[Note: This requires an OTel SDK with 4187]

Changes

  • Adds DisableMetricNameValidation connection string flag which will set the validation regex to .*

Considerations

  • We could expose a regex but my concern there is the SDK might move to some other mechanism in the future. I thought a simpler blanket disable option might get the job done without locking us into anything which might be hard to support long term.

/cc @dpk83

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Changes in public API reviewed

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 24, 2023
@dpk83
Copy link

dpk83 commented Feb 25, 2023

@CodeBlanch reminder so you don't miss this one :)

@CodeBlanch
Copy link
Member Author

@dpk83 Thanks! Just need #1042 to go in and then I can make this live for review to get it finished up.

@github-actions github-actions bot removed the Stale label Feb 25, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #1006 (89a7051) into main (3ca2b34) will increase coverage by 0.46%.
The diff coverage is 86.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   69.40%   69.87%   +0.46%     
==========================================
  Files         202      202              
  Lines        7668     7678      +10     
==========================================
+ Hits         5322     5365      +43     
+ Misses       2346     2313      -33     
Impacted Files Coverage Δ
...metry.Exporter.Instana/Implementation/Transport.cs 0.00% <0.00%> (ø)
...xporter.Geneva/Internal/ConnectionStringBuilder.cs 92.68% <75.00%> (-0.91%) ⬇️
...ry.Exporter.Geneva/Metrics/GenevaMetricExporter.cs 67.42% <100.00%> (+8.93%) ⬆️
.../OpenTelemetry.Exporter.Instana/InstanaExporter.cs 78.37% <100.00%> (-0.29%) ⬇️
...rter.Geneva/Metrics/GenevaMetricExporterOptions.cs 100.00% <0.00%> (+5.00%) ⬆️
...Geneva/Metrics/Transport/MetricEtwDataTransport.cs 75.00% <0.00%> (+50.00%) ⬆️
...r.Geneva/Metrics/GenevaMetricExporterExtensions.cs 90.00% <0.00%> (+90.00%) ⬆️

@CodeBlanch CodeBlanch marked this pull request as ready for review February 27, 2023 20:32
@CodeBlanch CodeBlanch requested a review from a team February 27, 2023 20:32
@utpilla utpilla added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Feb 27, 2023
@CodeBlanch CodeBlanch merged commit 3c17a16 into open-telemetry:main Feb 28, 2023
@CodeBlanch CodeBlanch deleted the geneva-metricnamevalidation branch February 28, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants