[frontend] Slowloading of images #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klucsik
force-pushed
the
slowloading-images
branch
from
80beac0
to
625780d
Compare
github-actions
bot
added
docs-update-required
There was a problem hiding this comment.
When trying to build and run this I'm getting the following error:
flagd | 2024-04-10T12:45:39.071Z error evaluator/fractional.go:30 parse fractional evaluation data: bucketing value not supplied and no targetingKey in context
flagd | github.com/open-feature/flagd/core/pkg/evaluator.(*Fractional).Evaluate
flagd | /src/core/pkg/evaluator/fractional.go:30
flagd | github.com/diegoholiveira/jsonlogic/v3.operation
flagd | /go/pkg/mod/github.com/diegoholiveira/jsonlogic/[email protected]/operation.go:15
flagd | github.com/diegoholiveira/jsonlogic/v3.apply
flagd | /go/pkg/mod/github.com/diegoholiveira/jsonlogic/[email protected]/jsonlogic.go:493
flagd | github.com/diegoholiveira/jsonlogic/v3.ApplyInterface
flagd | /go/pkg/mod/github.com/diegoholiveira/jsonlogic/[email protected]/jsonlogic.go:587
flagd | github.com/diegoholiveira/jsonlogic/v3.Apply
flagd | /go/pkg/mod/github.com/diegoholiveira/jsonlogic/[email protected]/jsonlogic.go:522
flagd | github.com/open-feature/flagd/core/pkg/evaluator.(*JSON).evaluateVariant
flagd | /src/core/pkg/evaluator/json.go:339
flagd | github.com/open-feature/flagd/core/pkg/evaluator.resolve[...]
flagd | /src/core/pkg/evaluator/json.go:276
flagd | github.com/open-feature/flagd/core/pkg/evaluator.(*JSON).ResolveAllValues
flagd | /src/core/pkg/evaluator/json.go:159
flagd | github.com/open-feature/flagd/core/pkg/service/flag-evaluation.(*FlagEvaluationService).ResolveAll
flagd | /src/core/pkg/service/flag-evaluation/flag_evaluator_v2.go:65
flagd | connectrpc.com/connect.NewUnaryHandler[...].func1
flagd | /go/pkg/mod/connectrpc.com/[email protected]/handler.go:52
flagd | connectrpc.com/connect.NewUnaryHandler[...].func2
flagd | /go/pkg/mod/connectrpc.com/[email protected]/handler.go:84
flagd | connectrpc.com/connect.(*Handler).ServeHTTP
flagd | /go/pkg/mod/connectrpc.com/[email protected]/handler.go:265
flagd | buf.build/gen/go/open-feature/flagd/connectrpc/go/flagd/evaluation/v1/evaluationv1connect.NewServiceHandler.func1
flagd | /go/pkg/mod/buf.build/gen/go/open-feature/flagd/connectrpc/[email protected]/flagd/evaluation/v1/evaluationv1connect/evaluation.connect.go:245
flagd | net/http.HandlerFunc.ServeHTTP
flagd | /usr/local/go/src/net/http/server.go:2166
flagd | github.com/open-feature/flagd/core/pkg/service/flag-evaluation.bufSwitchHandler.ServeHTTP
flagd | /src/core/pkg/service/flag-evaluation/connect_service.go:51
flagd | github.com/open-feature/flagd/core/pkg/service/flag-evaluation.(*ConnectService).setupServer.(*ConnectService).AddMiddleware.Middleware.Handler.func1.1
flagd | /src/core/pkg/service/middleware/metrics/http_metrics.go:105
flagd | github.com/open-feature/flagd/core/pkg/service/middleware/metrics.Middleware.Measure
flagd | /src/core/pkg/service/middleware/metrics/http_metrics.go:90
flagd | github.com/open-feature/flagd/core/pkg/service/flag-evaluation.(*ConnectService).setupServer.(*ConnectService).AddMiddleware.Middleware.Handler.func1
flagd | /src/core/pkg/service/middleware/metrics/http_metrics.go:104
flagd | net/http.HandlerFunc.ServeHTTP
flagd | /usr/local/go/src/net/http/server.go:2166
flagd | github.com/open-feature/flagd/core/pkg/service/flag-evaluation.(*ConnectService).setupServer.(*ConnectService).AddMiddleware.Middleware.Handler.(*Cors).Handler.func2
flagd | /go/pkg/mod/github.com/rs/[email protected]/cors.go:281
flagd | net/http.HandlerFunc.ServeHTTP
flagd | /usr/local/go/src/net/http/server.go:2166
flagd | golang.org/x/net/http2/h2c.h2cHandler.ServeHTTP
flagd | /go/pkg/mod/golang.org/x/[email protected]/http2/h2c/h2c.go:125
flagd | net/http.serverHandler.ServeHTTP
flagd | /usr/local/go/src/net/http/server.go:3137
flagd | net/http.(*conn).serve
flagd | /usr/local/go/src/net/http/server.go:2039
Hmmm, only fractional is the adServiceFailure. the session span attribute is missing. I don't think I1m touching those requests in my PR, I'll dig around if I can reproduce the issue. EDIT: I see the issue too, digging further |
|
The session var should be setted here: This is very far away from my changes, testing main now |
|
main works fine, but my PR somehow introduces these errors, I`ll investigate more |
klucsik
force-pushed
the
slowloading-images
branch
from
b44961f
to
4636590
Compare
|
These changes are working as expected, I find no problem in services behavior. But these error messages are emitted every time the react client makes a request against flagd. My suspect would be the interaction between https://github.com/open-feature/js-sdk and flagd. |
klucsik
force-pushed
the
slowloading-images
branch
from
4636590
to
7ab7183
Compare
|
The problem will be around this caching: https://github.com/open-feature/js-sdk-contrib/tree/main/libs/providers/flagd-web#caching |
klucsik
force-pushed
the
slowloading-images
branch
from
2810910
to
af1837f
Compare
austinlparker
approved these changes
Apr 30, 2024
|
at provider side, this open-feature/flagd#1295 solves the issue, we had in logs. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
…lter to envoy, add slowloading featureflag
Signed-off-by: Michael Beemer <[email protected]>
klucsik
force-pushed
the
slowloading-images
branch
from
25b4e3a
to
dffbefb
Compare
julianocosta89
approved these changes
May 13, 2024
This was referenced May 14, 2024
AlexPSplunk
pushed a commit
to splunk/edu-opentelemetry-demo
that referenced
this pull request
Jul 10, 2024
* [frontend] Add FeatureFlag Provider to client side, add http fault filter to envoy, add slowloading featureflag * refactor web sdk usage Signed-off-by: Michael Beemer <[email protected]> --------- Signed-off-by: Michael Beemer <[email protected]> Co-authored-by: Michael Beemer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add FeatureFlag Provider to client side.
Add http fault filter to envoy
Add slowloading featureflag, and modify the Product card element to disable caching and add the envoy http-fault header
Example of a slowly loaded image trace:
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additionsMaintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.