Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] ImageSlowLoading is not working #1732

Closed
klucsik opened this issue Oct 1, 2024 · 0 comments
Closed

[frontend] ImageSlowLoading is not working #1732

klucsik opened this issue Oct 1, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@klucsik
Copy link
Contributor

klucsik commented Oct 1, 2024

Bug Report

The ImageSlowLoad problem pattern is not working.

Symptom

When the flag switched on, the requests to /images/products/SOMEJPG doesn't contain the envoy fault header.

Reproduce

spin up the demo, set the imageSlowLoad to 5sec or 10sec, refresh frontend -> the images will load instantly

Additional Context

My suspicion is #1670, but I don't know yet why it would broke this.
In 1.11.0 the feature is working well. In 1.11.1, the bug is present.
The bulk of the relevant code is in src/frontend/components/ProductCard/ProductCard.tsx
The problem pattern is added in #1515. #1571 is also relevant.

@klucsik klucsik added the bug Something isn't working label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants