Passing parent context to SpanProcessor::OnStart() #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #552 +/- ##
==========================================
+ Coverage 94.31% 94.33% +0.02%
==========================================
Files 198 198
Lines 8806 8807 +1
==========================================
+ Hits 8305 8308 +3
+ Misses 501 499 -2
|
pyohannes
reviewed
Feb 2, 2021
Comment on lines
72
to
73
| const opentelemetry::trace::SpanContext &parent_context = | ||
| opentelemetry::trace::SpanContext::GetInvalid()) noexcept override; |
There was a problem hiding this comment.
Any reason for having a default value here? According to the spec this parameter is required, so I think we shouldn't make it easy to omit it.
There was a problem hiding this comment.
Yes right, it should be required parameter. I have modified the function prototype accordingly.
…metry-cpp into span-processor-parent-id
jsuereth
approved these changes
Feb 2, 2021
ThomsonTan
approved these changes
Feb 2, 2021
pyohannes
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per spec https://github.com/open-telemetry/opentelemetry-specification/blob/7e0c10260178b947777cf9c11d7f7ac4d4700725/specification/trace/sdk.md#onstart
SpanProcessor.onStart()should have a parent Context as parameter.fixes: #550