Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SpanProcessor.onStart to accept parent Context #550

Closed
lalitb opened this issue Feb 1, 2021 · 0 comments · Fixed by #552
Closed

Update SpanProcessor.onStart to accept parent Context #550

lalitb opened this issue Feb 1, 2021 · 0 comments · Fixed by #552
Labels
area:sdk release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs
Milestone

Comments

@lalitb
Copy link
Member

lalitb commented Feb 1, 2021

as per spec https://github.com/open-telemetry/opentelemetry-specification/blob/7e0c10260178b947777cf9c11d7f7ac4d4700725/specification/trace/sdk.md#onstart
SpanProcessor.on_start should have a parent Context as parameter

@lalitb lalitb added area:sdk priority:p2 Issues that are not blocking release:required-for-ga To be resolved before GA release labels Feb 1, 2021
@lalitb lalitb changed the title Update SpanProcessor.on_start to accept parent Context Update SpanProcessor.onStart to accept parent Context Feb 1, 2021
@lalitb lalitb added spec-compliance Not compliant to OpenTelemetry specs and removed priority:p2 Issues that are not blocking labels Feb 2, 2021
@lalitb lalitb added this to the 1.0.0-rc.1 milestone Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk release:required-for-ga To be resolved before GA release spec-compliance Not compliant to OpenTelemetry specs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant