Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into async changes #1472

Merged

Conversation

owent
Copy link
Member

@owent owent commented Jul 1, 2022

Changes

  • Merge main into async-changes
  • Add some comments for better understanding to async-changes of curl::HttpClient .

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

esigo and others added 30 commits March 21, 2022 07:02
* add owent as reviewer

* fix order
ThomsonTan and others added 24 commits June 2, 2022 19:24
…alues (open-telemetry#1427)

* validate histogram value

* handle Nan

* add changelog

* divide by 0 error on windows

* fix markdown lint
Signed-off-by: WenTao Ou <[email protected]>

# Conflicts:
#	.github/workflows/stale.yml
#	CHANGELOG.md
#	CMakeLists.txt
#	api/CMakeLists.txt
#	api/include/opentelemetry/common/spin_lock_mutex.h
#	api/include/opentelemetry/version.h
#	ci/do_ci.ps1
#	ci/do_ci.sh
#	docs/public/conf.py
#	examples/common/metrics_foo_library/foo_library.cc
#	examples/prometheus/prometheus.yml
#	exporters/otlp/test/otlp_http_log_exporter_test.cc
#	ext/include/opentelemetry/ext/http/client/curl/http_operation_curl.h
#	ext/src/http/client/curl/CMakeLists.txt
#	sdk/include/opentelemetry/sdk/version/version.h
#	sdk/src/version/version.cc
@owent owent requested a review from a team July 1, 2022 07:03
@owent
Copy link
Member Author

owent commented Jul 1, 2022

@lalitb Can we enable rebase and merge for this branch. Or there will be conflicts every time I merge main into async-changes.

@codecov
Copy link

codecov bot commented Jul 1, 2022

Codecov Report

❗ No coverage uploaded for pull request base (async-changes@daf5091). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##             async-changes    #1472   +/-   ##
================================================
  Coverage                 ?   84.72%           
================================================
  Files                    ?      155           
  Lines                    ?     4784           
  Branches                 ?        0           
================================================
  Hits                     ?     4053           
  Misses                   ?      731           
  Partials                 ?        0           

@lalitb lalitb merged commit 5e7ff72 into open-telemetry:async-changes Jul 1, 2022
@lalitb
Copy link
Member

lalitb commented Jul 1, 2022

@lalitb Can we enable rebase and merge for this branch. Or there will be conflicts every time I merge main into async-changes.

Have now removed all restrictions to this branch async-changes. Let me know if you see any issues.

@owent
Copy link
Member Author

owent commented Jul 2, 2022

@lalitb Can we enable rebase and merge for this branch. Or there will be conflicts every time I merge main into async-changes.

Have now removed all restrictions to this branch async-changes. Let me know if you see any issues.

image

I will update #1413 every time after main is merged into async-changes. The squash and merge will drop the merge history, if I rebase to entelemetry/async-changes and merge it to main, it will show conflicts again.

Is there any suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.