Skip to content

Commit

Permalink
Replace deprecated googletest API (#1327)
Browse files Browse the repository at this point in the history
  • Loading branch information
ThomsonTan authored Apr 15, 2022
1 parent e3304d7 commit defdfd2
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions sdk/test/metrics/sync_metric_storage_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,10 @@ TEST_P(WritableMetricStorageTestFixture, LongSumAggregation)
return true;
});
}
INSTANTIATE_TEST_CASE_P(WritableMetricStorageTestLong,
WritableMetricStorageTestFixture,
::testing::Values(AggregationTemporality::kCumulative,
AggregationTemporality::kDelta));
INSTANTIATE_TEST_SUITE_P(WritableMetricStorageTestLong,
WritableMetricStorageTestFixture,
::testing::Values(AggregationTemporality::kCumulative,
AggregationTemporality::kDelta));

TEST_P(WritableMetricStorageTestFixture, DoubleSumAggregation)
{
Expand Down Expand Up @@ -238,9 +238,9 @@ TEST_P(WritableMetricStorageTestFixture, DoubleSumAggregation)
return true;
});
}
INSTANTIATE_TEST_CASE_P(WritableMetricStorageTestDouble,
WritableMetricStorageTestFixture,
::testing::Values(AggregationTemporality::kCumulative,
AggregationTemporality::kDelta));
INSTANTIATE_TEST_SUITE_P(WritableMetricStorageTestDouble,
WritableMetricStorageTestFixture,
::testing::Values(AggregationTemporality::kCumulative,
AggregationTemporality::kDelta));

#endif

2 comments on commit defdfd2

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: defdfd2 Previous: e3304d7 Ratio
BM_NoopSpanCreation 2094.413174504015 ns/iter 793.8075427220239 ns/iter 2.64

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp api Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: defdfd2 Previous: e3304d7 Ratio
BM_ThreadYieldSpinLockThrashing/1/process_time/real_time 16.414284706115723 ms/iter 6.563107172648112 ms/iter 2.50

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.