Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic Conventions - script to automatic generation of semantic conventions c++ code #873

Closed
lalitb opened this issue Jun 23, 2021 · 4 comments · Fixed by #1497
Closed

Semantic Conventions - script to automatic generation of semantic conventions c++ code #873

lalitb opened this issue Jun 23, 2021 · 4 comments · Fixed by #1497
Labels
do-not-stale enhancement New feature or request good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers

Comments

@lalitb
Copy link
Member

lalitb commented Jun 23, 2021

As part of #868 and #872 , currently we are embedding semantic convention attributes manually into C++ code. This can be automated.
This ticket is to check the feasibility of automatic generation of C++ code from semantic convention YAML data model using Jinja template engine.

Reference:
YAML data model for semantic conventions: https://github.com/open-telemetry/opentelemetry-specification/tree/main/semantic_conventions
Semantic Conventions generator for markdown/code: https://github.com/open-telemetry/build-tools/tree/main/semantic-conventions#code-generator
@lalitb lalitb added enhancement New feature or request help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Jun 23, 2021
@lalitb lalitb mentioned this issue Jun 23, 2021
Merged
3 tasks
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 11, 2021
@lalitb lalitb added do-not-stale and removed Stale labels Nov 11, 2021
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Jan 11, 2022
@lalitb lalitb removed the Stale label Jan 11, 2022
@github-actions
Copy link

This issue was marked as stale due to lack of activity. It will be closed in 7 days if no furthur activity occurs.

@github-actions github-actions bot added the Stale label Mar 13, 2022
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this is still an issue.

@esigo esigo reopened this Mar 20, 2022
@esigo esigo removed the Stale label Mar 20, 2022
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 14, 2022
@marcalff
Automatically generate semantic conventions from the spec (open-telem…
15cf768 
…etry#873)
@marcalff marcalff mentioned this issue Jul 14, 2022
Merged
4 tasks
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 15, 2022
@marcalff
Automatically generate semantic conventions from the spec (open-telem…
380711c 
…etry#873)

Apply clang-format
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 15, 2022
@marcalff
Automatically generate semantic conventions from the spec (open-telem…
ffc1798 
…etry#873)

Added documentation.
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 15, 2022
@marcalff
Automatically generate semantic conventions from the spec (open-telem…
2923ef0 
…etry#873)

Fixed markdown format.

Added code to troubleshoot build failure.
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 15, 2022
@marcalff
Automatically generate semantic conventions from the spec (open-telem…
016aec2 
…etry#873)

Code cleanup.
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 15, 2022
@marcalff
Automatically generate semantic conventions from the spec (open-telem…
7f10a5e 
…etry#873)

Code cleanup for windows.
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 15, 2022
@marcalff
Automatically generate semantic conventions from the spec (open-telem…
ba2e49d 
…etry#873)

Removed #warning, not supported by the windows compiler.
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Jul 21, 2022
@marcalff
Automatically generate semantic conventions from the spec (open-telem…
1d508ba 
…etry#873)

Moved the windows work around to the template.
lalitb pushed a commit that referenced this issue Jul 21, 2022
@marcalff
Add automatically semantic conventions from the spec (#873) (#1497)
0948054
@marcalff marcalff mentioned this issue Jul 27, 2022
Closed
10 tasks
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this issue Dec 5, 2022
@marcalff @yxue
Add automatically semantic conventions from the spec (open-telemetry#873
d9ad0af 
) (open-telemetry#1497)
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this issue Dec 5, 2022
@marcalff @yxue
Add automatically semantic conventions from the spec (open-telemetry#873
567fb5b 
) (open-telemetry#1497)
@marcalff marcalff mentioned this issue Aug 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
do-not-stale enhancement New feature or request good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add automatically semantic conventions from the spec (#873) marcalff/opentelemetry-cpp
2 participants
@lalitb @esigo