Skip to content

Commit

Permalink
Add automatically semantic conventions from the spec (#873) (#1497)
Browse files Browse the repository at this point in the history
  • Loading branch information
marcalff authored Jul 21, 2022
1 parent beba414 commit 0948054
Show file tree
Hide file tree
Showing 19 changed files with 2,445 additions and 72 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Increment the:
* [EXPORTER] OTLP http exporter allow concurrency session ([#1209](https://github.com/open-telemetry/opentelemetry-cpp/pull/1209))
* [EXT] `curl::HttpClient` use `curl_multi_handle` instead of creating a thread
for every request and it's able to reuse connections now. ([#1317](https://github.com/open-telemetry/opentelemetry-cpp/pull/1317))
* [SEMANTIC CONVENTIONS] Upgrade to version 1.12.0 [#873](https://github.com/open-telemetry/opentelemetry-cpp/pull/873)

## [1.4.1] 2022-06-19

Expand Down
11 changes: 7 additions & 4 deletions RELEASING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,24 +2,27 @@

## Pre Release

1: Make sure all relevant changes for this release are included under
1: Upgrade to latest [semantic-conventions](docs/semantic-conventions.md)
if required.

2: Make sure all relevant changes for this release are included under
`Unreleased` section in `CHANGELOG.md` and are in language that non-contributors
to the project can understand.

2: Run the pre-release script. It creates a branch `pre_release_<new-tag>` and
3: Run the pre-release script. It creates a branch `pre_release_<new-tag>` and
updates `CHANGELOG.md` with the `<new-tag>`:

```sh
./buildscripts/pre_release.sh -t <new-tag>
```

3: Verify that CHANGELOG.md is updated properly:
4: Verify that CHANGELOG.md is updated properly:

```sh
git diff main
```

4: Push the changes to upstream and create a Pull Request on GitHub. Be sure to
5: Push the changes to upstream and create a Pull Request on GitHub. Be sure to
include the curated changes from the [Changelog](./CHANGELOG.md) in the
description.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
// https://github.com/open-telemetry/opentelemetry-specification/tree/v1.0.0/specification/trace/semantic_conventions
// and MAY will change in future.

// "This file is deprecated. Use opentelemetry/trace/semantic_conventions.h"

#pragma once

#include "opentelemetry/common/string_util.h"
Expand Down
Loading

1 comment on commit 0948054

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'OpenTelemetry-cpp sdk Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 0948054 Previous: beba414 Ratio
BM_BaselineBuffer/1 2536799.669265747 ns/iter 567574.5010375977 ns/iter 4.47
BM_LockFreeBuffer/1 1726830.9593200684 ns/iter 522532.4895246066 ns/iter 3.30

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.