Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add CI for instrumentation/glog #425

Merged
merged 9 commits into from
Apr 16, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 102 additions & 0 deletions .github/workflows/glog.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
name: glog

on:
push:
branches:
- '*'
path:
- 'instrumentation/glog/**'
- '.github/workflows/glog.yml'
pull_request:
branches: [main]
paths:
- 'instrumentation/glog/**'
- '.github/workflows/glog.yml'

jobs:
cmake_linux:
name: CMake Linux
runs-on: ubuntu-latest
steps:
- name: checkout googletest
uses: actions/checkout@v3
with:
repository: "google/googletest"
ref: "release-1.12.1"
path: "googletest"
submodules: "recursive"
marcalff marked this conversation as resolved.
Show resolved Hide resolved
- name: checkout glog
uses: actions/checkout@v3
with:
repository: "google/glog"
# TODO: upgrade to v0.7.0 and fix deprecation warnings
marcalff marked this conversation as resolved.
Show resolved Hide resolved
ref: "v0.6.0"
path: "glog"
submodules: "recursive"
- name: checkout opentelemetry-cpp-contrib
uses: actions/checkout@v3
with:
path: opentelemetry-cpp-contrib
# submodules: "recursive"
- name: checkout opentelemetry-cpp
uses: actions/checkout@v3
with:
repository: "open-telemetry/opentelemetry-cpp"
ref: "v1.14.2"
path: "opentelemetry-cpp"
submodules: "recursive"
- name: setup dependencies
run: |
sudo apt update -y
sudo apt install -y --no-install-recommends --no-install-suggests \
build-essential \
cmake \
ninja-build \
libssl-dev \
libcurl4-openssl-dev \
libprotobuf-dev \
protobuf-compiler \
libgmock-dev \
libgtest-dev \
marcalff marked this conversation as resolved.
Show resolved Hide resolved
libbenchmark-dev

# This is needed because libgmock-dev libgtest-dev installs 1.11,
# and 1.11 breaks the build.
- name: build googletest 1.12
run: |
mkdir -p "${GITHUB_WORKSPACE}/googletest/build"
cd "${GITHUB_WORKSPACE}/googletest/build"
cmake .. -G Ninja
cmake --build . -j$(nproc)
cmake --install . --prefix="${GITHUB_WORKSPACE}/sandbox"

- name: build glog
run: |
mkdir -p "${GITHUB_WORKSPACE}/glog/build"
cd "${GITHUB_WORKSPACE}/glog/build"
cmake .. -G Ninja
cmake --build . -j$(nproc)
cmake --install . --prefix="${GITHUB_WORKSPACE}/sandbox"

- name: build opentelemetry-cpp
run: |
mkdir -p "${GITHUB_WORKSPACE}/opentelemetry-cpp/build"
cd "${GITHUB_WORKSPACE}/opentelemetry-cpp/build"
cmake .. -G Ninja -DBUILD_TESTING=OFF -DWITH_BENCHMARK=OFF -DOPENTELEMETRY_INSTALL=ON
cmake --build . -j$(nproc)
cmake --install . --prefix="${GITHUB_WORKSPACE}/sandbox"

- name: build instrumentation/glog contrib
run: |
mkdir -p "${GITHUB_WORKSPACE}/instrumentation-glog/build"
cd "${GITHUB_WORKSPACE}/instrumentation-glog/build"
cmake ../../opentelemetry-cpp-contrib/instrumentation/glog \
-G Ninja \
-DCMAKE_PREFIX_PATH="${GITHUB_WORKSPACE}/sandbox" \
-DBUILD_TESTING=ON \
-DWITH_EXAMPLES=ON \
-DOPENTELEMETRY_INSTALL=ON
cmake --build . -j$(nproc)
ctest -j1 --output-on-failure
cmake --install . --prefix="${GITHUB_WORKSPACE}/sandbox"

8 changes: 6 additions & 2 deletions instrumentation/glog/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,10 @@ if(OPENTELEMETRY_INSTALL)
endif() # OPENTELEMETRY_INSTALL

if(BUILD_TESTING)
marcalff marked this conversation as resolved.
Show resolved Hide resolved
find_package(GTest 1.12 REQUIRED)

enable_testing()

set(testname sink_test)

include(GoogleTest)
Expand All @@ -81,8 +85,8 @@ if(BUILD_TESTING)
)

target_link_libraries(${testname} PRIVATE
gmock
gtest
GTest::gmock
GTest::gtest
glog::glog
opentelemetry-cpp::ostream_log_record_exporter
${this_target}
Expand Down
Loading