Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add CI for instrumentation/glog #425

Merged
merged 9 commits into from
Apr 16, 2024
Merged

[CI] Add CI for instrumentation/glog #425

merged 9 commits into from
Apr 16, 2024

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Apr 6, 2024 •
edited
Loading

Fixes #421

Fixed CMakeLists:

  • Require GTest 1.12.0. Building with 1.11 breaks the build due to a gtest bug.

Upgraded to google/glog 0.7.0

  • Fixed CMakeLists
  • Removed GLOG_VERSION_HAS_LOGMESSAGETIME
  • Fixed warnings related to timstamps.

@marcalff marcalff marked this pull request as ready for review April 6, 2024 22:17
@marcalff marcalff requested a review from a team April 6, 2024 22:17
@marcalff
Copy link
Member Author

marcalff commented Apr 7, 2024

@chusitoo FYI

chusitoo
chusitoo reviewed Apr 8, 2024
View reviewed changes
.github/workflows/glog.yml Outdated Show resolved Hide resolved
@marcalff marcalff added the instrumentation:glog GLog log appender label Apr 13, 2024
@marcalff marcalff merged commit 6217b44 into open-telemetry:main Apr 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chusitoo chusitoo chusitoo left review comments

@ThomsonTan ThomsonTan ThomsonTan approved these changes

Assignees

@ThomsonTan ThomsonTan

Labels
instrumentation:glog GLog log appender
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] Add CI for instrumentation/glog
3 participants
@marcalff @ThomsonTan @chusitoo