Create CODEOWNERS #12
Conversation
lalitb
requested review from
jsuereth,
ThomsonTan,
TomRoSystems,
pyohannes,
reyang and
maxgolov
.github/CODEOWNERS
Outdated
| # https://help.github.com/en/articles/about-code-owners | ||
| # | ||
|
|
||
| * @ThomsonTan @seemk @TomRoSystems @jsuereth @maxgolov @lalitb @pyohannes |
There was a problem hiding this comment.
Can we add something like @open-telemetry/cpp-contrib-approvers?
There was a problem hiding this comment.
We don't have this team for now. I will raise request to create one for this repo. Meanwhile we can discuss in this PR if all in the list agree to be there :)
There was a problem hiding this comment.
Have added this group now.
I like this idea. OpenTelemetry .NET Contrib is doing this and it seems to be working well. |
Good point. This was how my initial commit to this PR looked like ( 20f5559 ) We can discuss and revert back to something similar if all agree. |
Have switched to directory level owners now. |
Thanks! Btw safe to ignore the failing test. Reworked the tests in #10 a bit (also so it won't trigger on unrelated changes anymore) |
.github/CODEOWNERS
Outdated
| instrumentation/httpd/* @TomRoSystems @open-telemetry/cpp-contrib-approvers | ||
| instrumentation/nginx/* @seemk @open-telemetry/cpp-contrib-approvers |
There was a problem hiding this comment.
The problem with this is that * at the end of path will not match subdirectories.
Also I was thinking about some extra rule for CODEOWNERS file itself? I was not aware of this PR and created #13 but please close it was this one is merged.
There was a problem hiding this comment.
Good point. Have removed the *. I am not sure whether we want to have separate maintainers for contrib repo, or let approvers own this responsibility jointly here. We can discuss.
As of now, it's individual aliases in the CODEOWNERS file. I have taken liberty to take current approvers from core repo, along with @seemk and @TomRoSystems and make them default code owner. We can start adding component level owners once the repo grows.
Please raise a comment here if someone doesn't want to be in list, or would like to add someone here, or want to be owner of only specific component (currently nginx & httpd ) within repo ?
Once we all agree, we can raise request to create approver group accordingly. Also whether we need to have separate approvers and maintainers, or let one of the default approvers be responsible to merge the changes once we have sufficient approvals.
I can't find @seemk from Reviewers search list ( not sure why ) - Requesting him to please review, or if someone can add him as reviewer.