Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx: add test matrix, release builds #10

Merged
merged 41 commits into from
Mar 31, 2021

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Mar 29, 2021

  • Use only Docker for build and tests. This removed the redundant build step and allows for easier caching.
  • Use only release builds for testing.
  • Add more distros (Ubuntu 18.04, 20.10) along with mainline nginx (1.19.x) to the testing matrix.
  • Add Docker layer caching via buildx + Github Actions cache. Shaves off 15 minutes of build time from grpc on every distro.
  • Provide prebuilt libraries / artifacts for each distro and nginx configuration.
  • Add CI push trigger paths to nginx.yml so nginx builds won't activate on unrelated PRs.
  • Fix trace.json output file permissions for tests.

@seemk
Copy link
Contributor Author

seemk commented Mar 30, 2021

There, good to go now. Tests found an issue with the default nginx on Ubuntu 18.04: the package manager's nginx wasn't compiled with compatibility flags.

@seemk seemk mentioned this pull request Mar 30, 2021
@seemk seemk mentioned this pull request Mar 31, 2021
@lalitb lalitb merged commit bfc1343 into open-telemetry:main Mar 31, 2021
@marcalff marcalff added the instrumentation:nginx Nginx module label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants