-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs/platform-support.md] Add owners for linux/ppc64le #9371
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9371 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 345 345
Lines 18027 18027
=======================================
Hits 16253 16253
+ Misses 1444 1443 -1
- Partials 330 331 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @IBM-Currency-Helper, @adilhusain-s and @seth-priya, please approve and we can merge this change 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@seth-priya We need approvals from the other two accounts, can you help with that? |
Sorry @mx-psi didn't get you, were you looking for an approval on this PR for adding the other two accounts, or creating a membership request for them (@adilhusain-s already has one #8528 ) or is there something else you wanted me to look at? apologies again for missing the context ... |
I just want @adilhusain-s and @IBM-Currency-Helper to approve this PR :) OTel membership is also nice to have, and I am happy to sponsor you for this, but it is not an explicit requirement for platform owners at this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On behalf of the ICH team at IBM, I approve this request. --gh
@codeboten I believe this is ready to merge 🎉 |
Description: Add @IBM-Currency-Helper, @adilhusain-s and @seth-priya as owners for the
linux/ppc64le
platform.Link to tracking Issue: Fixes #8528