Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/platform-support.md] Add owners for linux/ppc64le #9371

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 24, 2024

Description: Add @IBM-Currency-Helper, @adilhusain-s and @seth-priya as owners for the linux/ppc64le platform.

Link to tracking Issue: Fixes #8528

@mx-psi mx-psi requested review from a team and Aneurysm9 January 24, 2024 11:54
@mx-psi mx-psi added Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests labels Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b076408) 90.15% compared to head (e518c72) 90.15%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9371   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files         345      345           
  Lines       18027    18027           
=======================================
  Hits        16253    16253           
+ Misses       1444     1443    -1     
- Partials      330      331    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IBM-Currency-Helper, @adilhusain-s and @seth-priya, please approve and we can merge this change 👍🏻

Copy link

@seth-priya seth-priya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mx-psi mx-psi linked an issue Jan 25, 2024 that may be closed by this pull request
7 tasks
@mx-psi
Copy link
Member Author

mx-psi commented Jan 29, 2024

@seth-priya We need approvals from the other two accounts, can you help with that?

@seth-priya
Copy link

@seth-priya We need approvals from the other two accounts, can you help with that?

Sorry @mx-psi didn't get you, were you looking for an approval on this PR for adding the other two accounts, or creating a membership request for them (@adilhusain-s already has one #8528 ) or is there something else you wanted me to look at? apologies again for missing the context ...

@mx-psi
Copy link
Member Author

mx-psi commented Jan 30, 2024

@seth-priya We need approvals from the other two accounts, can you help with that?

Sorry @mx-psi didn't get you, were you looking for an approval on this PR for adding the other two accounts, or creating a membership request for them (@adilhusain-s already has one #8528 ) or is there something else you wanted me to look at? apologies again for missing the context ...

I just want @adilhusain-s and @IBM-Currency-Helper to approve this PR :) OTel membership is also nice to have, and I am happy to sponsor you for this, but it is not an explicit requirement for platform owners at this time.

Copy link

@IBM-Currency-Helper IBM-Currency-Helper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On behalf of the ICH team at IBM, I approve this request. --gh

@mx-psi
Copy link
Member Author

mx-psi commented Jan 31, 2024

@codeboten I believe this is ready to merge 🎉

@mx-psi mx-psi merged commit cae7e2a into open-telemetry:main Feb 5, 2024
32 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry Skip Contrib Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Find owners for the linux/ppc64le platform Find owners for orphan platforms
6 participants