[exporterhelper] Do not re-enqueue failed requests #9090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
remove-reqeueing
branch
5 times, most recently
from
dcf9229 to
ed43c53
Compare
|
@swiatekm-sumo, PTAL |
dmitryax
force-pushed
the
remove-reqeueing
branch
from
ed43c53 to
6da1a7c
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9090 +/- ##
==========================================
- Coverage 91.52% 91.49% -0.03%
==========================================
Files 319 320 +1
Lines 17218 17194 -24
==========================================
- Hits 15758 15731 -27
- Misses 1163 1166 +3
Partials 297 297 ☔ View full report in Codecov by Sentry. |
dmitryax
force-pushed
the
remove-reqeueing
branch
2 times, most recently
from
c2bc57a to
9a92d0a
Compare
swiatekm
reviewed
Dec 14, 2023
The current re-enqueuing behavior is not obvious and cannot be configured. It takes place only for persistent queue and only if `retry_on_failure::enabled=true` even if `retry_on_failure` is a setting for a different backoff retry strategy. This change removes the re-enqueuing behavior. Consider increasing `retry_on_failure::max_elapsed_time` to reduce chances of data loss.
dmitryax
force-pushed
the
remove-reqeueing
branch
from
9a92d0a to
46a11f8
Compare
swiatekm
approved these changes
Dec 14, 2023
bogdandrutu
approved these changes
Dec 15, 2023
sokoide
pushed a commit
to sokoide/opentelemetry-collector
that referenced
this pull request
Dec 18, 2023
The current re-enqueuing behavior is not obvious and cannot be configured. It takes place only for persistent queue and only if `retry_on_failure::enabled=true` even if `retry_on_failure` is a setting for a different backoff retry strategy. This change removes the re-enqueuing behavior in favor of the `retry_on_failure` option. Consider increasing `retry_on_failure::max_elapsed_time` to reduce chances of data loss. Resolves open-telemetry#8382
carsonip
added a commit
to carsonip/opentelemetry-collector
that referenced
this pull request
Mar 7, 2024
Requeuing was removed in open-telemetry#9090. Update docs accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current re-enqueuing behavior is not obvious and cannot be configured. It takes place only for persistent queue and only if
retry_on_failure::enabled=trueeven ifretry_on_failureis a setting for a different backoff retry strategy.This change removes the re-enqueuing behavior in favor of the
retry_on_failureoption. Consider increasingretry_on_failure::max_elapsed_timeto reduce chances of data loss.Resolves #8382