Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix storage client leak in persistent queue when shutdown #9122

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Dec 15, 2023

No changelog, bug was not released.

@bogdandrutu bogdandrutu requested review from a team and mx-psi December 15, 2023 19:19
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6b12cc3) 91.50% compared to head (881e098) 91.51%.

Files Patch % Lines
...porter/exporterhelper/internal/persistent_queue.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9122      +/-   ##
==========================================
+ Coverage   91.50%   91.51%   +0.01%     
==========================================
  Files         320      320              
  Lines       17189    17185       -4     
==========================================
- Hits        15728    15727       -1     
+ Misses       1163     1161       -2     
+ Partials      298      297       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.chloggen/fixleak.yaml Outdated Show resolved Hide resolved
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Dec 15, 2023
@bogdandrutu bogdandrutu changed the title Fix storage client leak in persistent queue when shutdown [chore] Fix storage client leak in persistent queue when shutdown Dec 15, 2023
@bogdandrutu bogdandrutu merged commit 16e0d9f into open-telemetry:main Dec 15, 2023
32 of 35 checks passed
@bogdandrutu bogdandrutu deleted the fixleak branch December 15, 2023 19:58
@github-actions github-actions bot added this to the next release milestone Dec 15, 2023
sokoide pushed a commit to sokoide/opentelemetry-collector that referenced this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants