Add component node build methods #7026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.37% // Head: 90.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7026 +/- ##
==========================================
- Coverage 90.37% 90.01% -0.36%
==========================================
Files 243 243
Lines 14599 14657 +58
==========================================
Hits 13194 13194
- Misses 1137 1195 +58
Partials 268 268
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
djaglowski
force-pushed
the
connectors-node-buiders
branch
from
61aac79 to
ee3f056
Compare
dmitryax
approved these changes
Jan 26, 2023
Yes indeed. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6700
This PR continues with the bottom up approach started in #6895. It defines a
buildmethod for each node type. The receiver, processor, and exporter nodes are able to wrap the preexistingbuild<Type>functions frompipelines.go. The connector node has a fully new implementation since it will not be shared by the otherpipelinesimplementation.