Remove unnecessary interface in service/nodes.go #7013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.36% // Head: 90.36% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #7013 +/- ##
=======================================
Coverage 90.36% 90.36%
=======================================
Files 243 243
Lines 14598 14598
=======================================
Hits 13191 13191
Misses 1138 1138
Partials 269 269
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
This would remove the |
djaglowski
force-pushed
the
connectors-nodes-cleanup
branch
from
45f164a to
65242d8
Compare
djaglowski
force-pushed
the
connectors-nodes-cleanup
branch
from
65242d8 to
e51bb01
Compare
bogdandrutu
reviewed
Jan 25, 2023
bogdandrutu
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This interface was part of #6700 but has been refactored out in the latest implementation.