Add entry point to build graph-based pipelines #7023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
added
Skip Changelog
djaglowski
force-pushed
the
connectors-entry-point
branch
from
702729b to
46be367
Compare
mx-psi
reviewed
Jan 25, 2023
djaglowski
force-pushed
the
connectors-entry-point
branch
from
46be367 to
a322015
Compare
Codecov ReportBase: 90.33% // Head: 90.29% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #7023 +/- ##
==========================================
- Coverage 90.33% 90.29% -0.05%
==========================================
Files 245 245
Lines 14644 14654 +10
==========================================
+ Hits 13229 13232 +3
- Misses 1146 1152 +6
- Partials 269 270 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Please rebase |
djaglowski
force-pushed
the
connectors-entry-point
branch
from
a322015 to
7813479
Compare
|
Thanks, this has been rebased |
jpkrohling
approved these changes
Jan 26, 2023
mx-psi
approved these changes
Jan 26, 2023
|
Can this be merged? |
dmitryax
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6700
The remainder of the connectors implementation is concerned with setting up the component graph and building each node's associated component. I believe the best way to add these capabilities incrementally will be to so in a top-down way.
#6700 contains extensive testing of the graph as a whole. However, these tests interface primarily with the graph's built components. I'm not seeing a reasonable way to include coverage for a partially built graph, which I expect we would have if we follow the contribution path I've described above. My hope is that we can move forward for a few PRs based on the understanding that test coverage will be comprehensive in the end.
This PR adds the entry point to building the component graph. This entry point is hidden behind the same feature gate that was already to the
otelcolpackage in #6964. However, it moves the gate to theserviceso that both packages can use it.