Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connectors to otelcol config #6964

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

djaglowski
Copy link
Member

Part of #6700

This PR adds connectors to the otelcol.Config and updates associated config provider and unmarshaler.

@djaglowski djaglowski added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jan 18, 2023
@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 90.65% // Head: 90.63% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (e12df8f) compared to base (aa3619c).
Patch coverage: 75.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6964      +/-   ##
==========================================
- Coverage   90.65%   90.63%   -0.02%     
==========================================
  Files         241      241              
  Lines       14518    14529      +11     
==========================================
+ Hits        13161    13169       +8     
- Misses       1089     1091       +2     
- Partials      268      269       +1     
Impacted Files Coverage Δ
otelcol/config.go 95.08% <70.00%> (-4.92%) ⬇️
otelcol/configprovider.go 79.06% <100.00%> (+0.49%) ⬆️
otelcol/unmarshaler.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djaglowski djaglowski marked this pull request as ready for review January 18, 2023 17:19
@djaglowski djaglowski requested review from a team and bogdandrutu January 18, 2023 17:19
@djaglowski djaglowski force-pushed the connectors-otelcol branch 3 times, most recently from 60535e7 to 6e594ef Compare January 19, 2023 15:15
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, needs a rebase

@djaglowski
Copy link
Member Author

@codeboten, thanks for the review. Rebased.

@bogdandrutu bogdandrutu merged commit 701fe0d into open-telemetry:main Jan 23, 2023
@djaglowski djaglowski deleted the connectors-otelcol branch January 23, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:connector Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants