Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consumer] split consumer into its own module #6557

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

codeboten
Copy link
Contributor

This is part of #6186

@codeboten codeboten requested review from a team and mx-psi November 15, 2022 22:11
.chloggen/split-consumer.yaml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 91.35% // Head: 91.10% // Decreases project coverage by -0.24% ⚠️

Coverage data is based on head (702c4cf) compared to base (a8d6280).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6557      +/-   ##
==========================================
- Coverage   91.35%   91.10%   -0.25%     
==========================================
  Files         241      241              
  Lines       13885    13887       +2     
==========================================
- Hits        12684    12652      -32     
- Misses        956      995      +39     
+ Partials      245      240       -5     
Impacted Files Coverage Δ
receiver/otlpreceiver/config.go 94.44% <ø> (ø)
consumer/consumertest/base_consumer.go 0.00% <0.00%> (-100.00%) ⬇️
component/config.go 0.00% <0.00%> (-40.00%) ⬇️
component/component.go 62.22% <0.00%> (-37.78%) ⬇️
component/componenttest/nop_factories.go 0.00% <0.00%> (-29.42%) ⬇️
component/extension.go 86.66% <0.00%> (-13.34%) ⬇️
component/exporter.go 96.07% <0.00%> (-3.93%) ⬇️
component/receiver.go 96.07% <0.00%> (-3.93%) ⬇️
component/processor.go 96.07% <0.00%> (-3.93%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@codeboten codeboten merged commit 2454cfb into open-telemetry:main Nov 16, 2022
@codeboten codeboten deleted the codeboten/split-consumer branch November 16, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants