Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split consumer into its own module #6186

Closed
Tracked by #5992
jpkrohling opened this issue Sep 29, 2022 · 0 comments
Closed
Tracked by #5992

Split consumer into its own module #6186

jpkrohling opened this issue Sep 29, 2022 · 0 comments
Assignees
@codeboten

Comments

@jpkrohling
Copy link
Member

jpkrohling commented Sep 29, 2022 •
edited
Loading

From @bogdandrutu:

I think current client should be merged into the consumer. Since the client information (the info that we add about connection/request) is consumed by the Consumers (Processor/Exporter are all consumers).

I'm not sure I agree 100% with this yet, but will have a thought at a later point and address in a follow-up PR
@jpkrohling jpkrohling mentioned this issue Sep 29, 2022
Closed
11 tasks
@jpkrohling jpkrohling changed the title consumer, I think current client should be merged into the consumer. Since the client information (the info that we add about connection/request) is consumed by the Consumers (Processor/Exporter are all consumers). Split consumer into its own module Sep 29, 2022
@codeboten codeboten self-assigned this Nov 15, 2022
codeboten pushed a commit to codeboten/opentelemetry-collector that referenced this issue Nov 15, 2022
[consumer] split consumer into its own module
f5a652e 
This is part of open-telemetry#6186
@codeboten codeboten mentioned this issue Nov 15, 2022
Merged
codeboten pushed a commit that referenced this issue Nov 16, 2022
@mx-psi
[consumer] split consumer into its own module (#6557)
2454cfb 
This is part of #6186

Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpkrohling @codeboten @bogdandrutu