[test] fix flaky telemetry zpages test #6324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 92.06% // Head: 91.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6324 +/- ##
==========================================
- Coverage 92.06% 91.88% -0.18%
==========================================
Files 219 235 +16
Lines 13242 13673 +431
==========================================
+ Hits 12191 12564 +373
- Misses 828 884 +56
- Partials 223 225 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
bogdandrutu
reviewed
Oct 17, 2022
paivagustavo
force-pushed
the
gustavo/fix_flaky_collector_tests
branch
from
197964b to
d75fc60
Compare
paivagustavo
changed the title
|
@bogdandrutu I've removed the |
bogdandrutu
approved these changes
Oct 25, 2022
bogdandrutu
added
the
Skip Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Integration tests failed because
zpagesfailed to start (because the port was not available, see #6323 (comment) for more context) which led to leak oftelemetryInitializerresources.Link to tracking Issue: #6323