Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky metrics tests after #6297, never seen this before #6323

Closed
bogdandrutu opened this issue Oct 15, 2022 · 1 comment
Closed

Flaky metrics tests after #6297, never seen this before #6323

bogdandrutu opened this issue Oct 15, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@bogdandrutu
Copy link
Member

See https://github.com/open-telemetry/opentelemetry-collector/actions/runs/3255902434/jobs/5345701291

@bogdandrutu bogdandrutu added the bug Something isn't working label Oct 15, 2022
@paivagustavo
Copy link
Member

This is not related to #6297, I've tracked down the same test error a month ago: commit and ci, there should be other occurrences but stopped here.

But since I started to debug this, I managed to discover that the collector integration test always try to register zpages to the same address (127.0.0.1:55679) instead of using the helper testutil.GetAvailableLocalAddress(t) to get an available address. Occasionally, this port is not be available, possibly because of this, ending the test with the error:

failed to start extensions: listen tcp 127.0.0.1:55679: bind: An attempt was made to access a socket in a way forbidden by its access permissions.

The following tests that fails with a different view with the same name is already registered is because we don't clean up the telemetryInitializer when the collector.service.Start(ctx) errors, in this case because the zpage extension was not started properly. Similar to #6238.

This can lead to other resource leaks because we don't clean up any resource that has been correctly started. For example, if an error happens on the NotifyPipelineReady function, all started extensions and pipelines would not be shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants