-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pdata] Rename Map.Upsert* methods to Map.Put* #6064
[pdata] Rename Map.Upsert* methods to Map.Put* #6064
Conversation
2234e86
to
14714ae
Compare
14714ae
to
c7f1549
Compare
Codecov ReportBase: 91.73% // Head: 91.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6064 +/- ##
==========================================
- Coverage 91.73% 91.59% -0.15%
==========================================
Files 217 217
Lines 13411 13425 +14
==========================================
- Hits 12302 12296 -6
- Misses 886 906 +20
Partials 223 223
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Will wait until after the SIG meeting to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have to merge with the failing contrib check
@dmitryax's pr open-telemetry/opentelemetry-collector-contrib#14118 solves this 👍🏻
@codeboten I missed one usage of UpsertEmptyBytes open-telemetry/opentelemetry-collector-contrib#14123 so it's still failing |
Link to tracking Issue: #6059