Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pdata] Rename Map.Upsert* methods to Map.Put* #6064

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

dmitryax
Copy link
Member

Link to tracking Issue: #6059

@dmitryax dmitryax requested review from a team and codeboten September 13, 2022 23:47
@dmitryax dmitryax force-pushed the rename-upsert-to-put branch from 2234e86 to 14714ae Compare September 13, 2022 23:49
@dmitryax dmitryax force-pushed the rename-upsert-to-put branch from 14714ae to c7f1549 Compare September 13, 2022 23:50
@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Base: 91.73% // Head: 91.59% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (c7f1549) compared to base (98c787a).
Patch coverage: 36.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6064      +/-   ##
==========================================
- Coverage   91.73%   91.59%   -0.15%     
==========================================
  Files         217      217              
  Lines       13411    13425      +14     
==========================================
- Hits        12302    12296       -6     
- Misses        886      906      +20     
  Partials      223      223              
Impacted Files Coverage Δ
pdata/pcommon/common.go 91.14% <36.36%> (-3.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bogdandrutu
Copy link
Member

Will wait until after the SIG meeting to merge.

@mx-psi mx-psi added the release:blocker The issue must be resolved before cutting the next release label Sep 14, 2022
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to merge with the failing contrib check

@dmitryax's pr open-telemetry/opentelemetry-collector-contrib#14118 solves this 👍🏻

@dmitryax
Copy link
Member Author

@codeboten I missed one usage of UpsertEmptyBytes open-telemetry/opentelemetry-collector-contrib#14123 so it's still failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:blocker The issue must be resolved before cutting the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants