You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #5998, we found out that Map.Insert* and Map.Update* methods are not that useful as we probably initially expected and we decided to go with Map.Upsert* that suites all the use cases and can be applied to all the Value types consistently. Having Map.Upsert* alone doesn't seem like the best name pick, so we should consider other names. I see the following options:
Map.Put* (Put, PutString, PutSlice, PutMap etc). Inspired by Java and REST API.
In #5998, we found out that
Map.Insert*
andMap.Update*
methods are not that useful as we probably initially expected and we decided to go withMap.Upsert*
that suites all the use cases and can be applied to all theValue
types consistently. HavingMap.Upsert*
alone doesn't seem like the best name pick, so we should consider other names. I see the following options:Map.Put*
(Put
,PutString
,PutSlice
,PutMap
etc). Inspired by Java and REST API.Map.Store*
(Store
,StoreString
,StoreSlice
,StoreMap
etc). Inspired by https://pkg.go.dev/sync#Map.Store.Map.Set*
(Set
,SetString
,SetSlice
,SetMap
etc).So we need to pick one.
cc @open-telemetry/collector-approvers
The text was updated successfully, but these errors were encountered: