[exporter/logging] log min and max for histograms #5520
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5520 +/- ##
==========================================
+ Coverage 90.87% 90.88% +0.01%
==========================================
Files 191 191
Lines 11362 11378 +16
==========================================
+ Hits 10325 10341 +16
Misses 812 812
Partials 225 225
Continue to review full report at Codecov.
|
pichlermarc
changed the title
internal/otlptext/databuffer.go
Outdated
| b.logEntry("Min: %f", p.Min()) | ||
| b.logEntry("Max: %f", p.Max()) |
There was a problem hiding this comment.
if p.HasMin() {
b.logEntry("Min: %f", p.Min())
}
internal/otlptext/databuffer.go
Outdated
| @@ -146,6 +157,14 @@ func (b *dataBuffer) logExponentialHistogramDataPoints(ps pmetric.ExponentialHis | |||
| b.logEntry("Count: %d", p.Count()) | |||
| b.logEntry("Sum: %f", p.Sum()) | |||
There was a problem hiding this comment.
Sum should be optional for exponential histogram as well. I'll open an issue
There was a problem hiding this comment.
Now that #5530 merged, please update the PR to check HasSum here as well
There was a problem hiding this comment.
Done in 2883283. Thanks for updating the proto version! 🙂
|
go 1.18 unit tests are currently failing. I'm investigating. |
Description:
The
loggingexporter did not showminandmaxof histograms. This PR adds logging forminandmaxon both Histograms and Exponential Histograms.Link to tracking Issue: Fixes #5518
Testing:
minandmaxfields on histograms during implementation of feat(sdk-metrics-base): implement min/max recording for Histograms opentelemetry-js#3032