Skip to content

Commit

Permalink
Ensure extensions are only shut down once (#5532)
Browse files Browse the repository at this point in the history
  • Loading branch information
rmfitzpatrick authored Jun 13, 2022
1 parent 071d196 commit 277f98e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
### 🧰 Bug fixes 🧰

- Update sum field of exponential histograms to make it optional (#5530)
- Remove redundant extension shutdown call (#5532)

## v0.53.0 Beta

Expand Down
5 changes: 0 additions & 5 deletions service/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,11 +145,6 @@ func (srv *service) Shutdown(ctx context.Context) error {
errs = multierr.Append(errs, fmt.Errorf("failed to shutdown extensions: %w", err))
}

srv.telemetry.Logger.Info("Stopping extensions...")
if err := srv.host.builtExtensions.ShutdownAll(ctx); err != nil {
errs = multierr.Append(errs, fmt.Errorf("failed to shutdown extensions: %w", err))
}

// TODO: Shutdown TracerProvider, MeterProvider, and Sync Logger.
return errs
}

0 comments on commit 277f98e

Please sign in to comment.