Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename config.NewID to config.NewComponentID and config.NewIDFromString to config.NewComponentIDFromString #4137

Conversation

JamesJHPark
Copy link
Contributor

@JamesJHPark JamesJHPark commented Sep 28, 2021

Description:
This PR is to rename config.NewID to config.NewComponentID and config.NewIDFromString to config.NewComponentIDFromString for naming consistency.

Link to tracking Issue:
Fixes #4105

@JamesJHPark JamesJHPark requested review from a team and Aneurysm9 September 28, 2021 01:07
@JamesJHPark JamesJHPark changed the title Rename config.NewID and config.NewIDFromString to config.NewComponentID and config.NewComponentIDFromString Rename config.NewID to config.NewComponentID and config.NewIDFromString to config.NewComponentIDFromString Sep 28, 2021
@bogdandrutu
Copy link
Member

@JamesJHPark please rebase, do you have a PR ready for contrib?

@JamesJHPark
Copy link
Contributor Author

JamesJHPark commented Sep 29, 2021

@JamesJHPark please rebase, do you have a PR ready for contrib?

Thank you, I will rebase and file a PR for contrib.

@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #4137 (6a72284) into main (e43250e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4137   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files         174      174           
  Lines       10198    10198           
=======================================
  Hits         8964     8964           
  Misses        984      984           
  Partials      250      250           
Impacted Files Coverage Δ
component/componenttest/nop_exporter.go 100.00% <100.00%> (ø)
component/componenttest/nop_extension.go 100.00% <100.00%> (ø)
component/componenttest/nop_processor.go 100.00% <100.00%> (ø)
component/componenttest/nop_receiver.go 100.00% <100.00%> (ø)
config/configgrpc/configgrpc.go 92.45% <100.00%> (ø)
config/confighttp/confighttp.go 100.00% <100.00%> (ø)
config/configunmarshaler/defaultunmarshaler.go 95.54% <100.00%> (ø)
config/identifiable.go 100.00% <100.00%> (ø)
exporter/loggingexporter/factory.go 73.21% <100.00%> (ø)
exporter/otlpexporter/factory.go 91.30% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e43250e...6a72284. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent name "config.NewID" and "config.NewIDFromString"
5 participants