-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename config.NewID
to config.NewComponentID
and config.NewIDFromString
to config.NewComponentIDFromString
#4137
Conversation
config.NewID
and config.NewIDFromString
to config.NewComponentID
and config.NewComponentIDFromString
config.NewID
to config.NewComponentID
and config.NewIDFromString
to config.NewComponentIDFromString
@JamesJHPark please rebase, do you have a PR ready for contrib? |
Thank you, I will rebase and file a PR for contrib. |
Codecov Report
@@ Coverage Diff @@
## main #4137 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 174 174
Lines 10198 10198
=======================================
Hits 8964 8964
Misses 984 984
Partials 250 250
Continue to review full report at Codecov.
|
Description:
This PR is to rename
config.NewID
toconfig.NewComponentID
andconfig.NewIDFromString
toconfig.NewComponentIDFromString
for naming consistency.Link to tracking Issue:
Fixes #4105