Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent name "config.NewID" and "config.NewIDFromString" #4105

Closed
bogdandrutu opened this issue Sep 24, 2021 · 1 comment · Fixed by #4137
Closed

Inconsistent name "config.NewID" and "config.NewIDFromString" #4105

bogdandrutu opened this issue Sep 24, 2021 · 1 comment · Fixed by #4137
Assignees
@JamesJHPark
Labels
bug Something isn't working
Milestone
core-release-v37

Comments

@bogdandrutu
Copy link
Member

https://github.com/open-telemetry/opentelemetry-collector/blob/main/config/identifiable.go#L43

They should be named "config.NewComponentID" and "config.NewComponentIDFromString"
@bogdandrutu bogdandrutu added the bug Something isn't working label Sep 24, 2021
@bogdandrutu bogdandrutu added this to the core-release-v37 milestone Sep 24, 2021
@JamesJHPark
Copy link
Contributor

@alolita - please assign me this issue

@JamesJHPark JamesJHPark mentioned this issue Sep 28, 2021
Merged
tigrannajaryan pushed a commit that referenced this issue Sep 29, 2021
@JamesJHPark
Rename config.NewID to config.NewComponentID and `config.NewIDFro…
85b8094 
…mString` to `config.NewComponentIDFromString` (#4137)

This PR is to rename `config.NewID` to `config.NewComponentID` and `config.NewIDFromString` to `config.NewComponentIDFromString` for naming consistency.  

**Link to tracking Issue:** 
Fixes #4105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JamesJHPark JamesJHPark

Labels
bug Something isn't working
Projects
None yet
Milestone
core-release-v37
2 participants
@bogdandrutu @JamesJHPark