Added a version tag to the collector's own telemetry metrics #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@emaderer please give me some details about why this is needed? Also in OpenCensus there is a concept of constant labels that you can use :) |
|
Here is the API you need to use https://github.com/census-ecosystem/opencensus-go-exporter-prometheus/blob/master/prometheus.go#L50 |
emaderer
changed the title
Added description, thanks 👍 |
bogdandrutu
reviewed
Sep 8, 2021
Comment on lines
+54
to
58
| addCollectorVersionPtr = flags.Bool( | ||
| "add-collector-version", | ||
| true, | ||
| "Flag to control the addition of 'service.version' to the collector metrics.") | ||
| } |
There was a problem hiding this comment.
I'll wait until https://github.com/open-telemetry/opentelemetry-collector/milestone/21 is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a version tag to the collector's own telemetry metrics because today when looking at those metrics there is no way to know the collector's version, this can also help to know what collector versions are running out there.