Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move telemetry-related settings to the config file #3843

Closed
kirbyquerby opened this issue Aug 17, 2021 · 3 comments
Closed

move telemetry-related settings to the config file #3843

kirbyquerby opened this issue Aug 17, 2021 · 3 comments
Assignees

Comments

@kirbyquerby
Copy link
Member

context: #3816 (comment)

The metrics-level and metrics-backend configuration for internal metrics are currently configured using command-line flags. Since config is already loaded by the time telemetry collection is set up, we should be able to instead read these values from config instead, eg:

...
service:
  telemetry:
    metrics-level: basic
    metrics-backend: opencensus
  pipelines:  
...

/cc @tigrannajaryan @bogdandrutu @odeke-em

@alolita
Copy link
Member

alolita commented Sep 2, 2021

@Aneurysm9 @codeboten can you please review the PR by @kirbyquerby ty!

@tigrannajaryan
Copy link
Member

We will also likely want to specify in this same section the Resource attributes that the Collector will use in its own telemetry, particularly:

  • service.namespace
  • service.name (default to e.g. "io.opentelemetry.collector")
  • service.instance.id (default to autogenerated as currently)
  • other user-specified attributes.

For example:

service:
  telemetry:
    resource:
      service.namespace: onlineshop
      deployment.environment: production

@bogdandrutu
Copy link
Member

The initial request from this issue is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants