Remove Java-like concrete type naming #3160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Go, we tend to not to name concrete types with prefixes like *Imp or *Impl like in Java. Renaming exporterImp to exporter.
bogdandrutu
approved these changes
May 13, 2021
|
Thank you @rakyll! |
dashpole
pushed a commit
to dashpole/opentelemetry-collector
that referenced
this pull request
Jun 14, 2021
In Go, we tend to not to name concrete types with prefixes like *Imp or *Impl like in Java. Renaming exporterImp to exporter.
ankitnayan
pushed a commit
to SigNoz/opentelemetry-collector
that referenced
this pull request
Jul 27, 2021
In Go, we tend to not to name concrete types with prefixes like *Imp or *Impl like in Java. Renaming exporterImp to exporter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Go, we tend to not to name concrete types with prefixes like *Imp or *Impl like in Java. Renaming exporterImp to exporter to keep it simple.