Remove Java-like concrete type naming (#3160)

In Go, we tend to not to name concrete types with prefixes like *Imp or *Impl like in Java. Renaming exporterImp to exporter.
open-telemetry · May 13, 2021 · ca20d0e · ca20d0e
1 parent 40c439a
commit ca20d0e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/exporter/otlpexporter/otlp.go b/exporter/otlpexporter/otlp.go
@@ -36,22 +36,22 @@ import (
 	otlptrace "go.opentelemetry.io/collector/internal/data/protogen/collector/trace/v1"
 )
 
-type exporterImp struct {
+type exporter struct {
 	// Input configuration.
 	config *Config
 	w      *grpcSender
 }
 
 // Crete new exporter and start it. The exporter will begin connecting but
 // this function may return before the connection is established.
-func newExporter(cfg config.Exporter) (*exporterImp, error) {
+func newExporter(cfg config.Exporter) (*exporter, error) {
 	oCfg := cfg.(*Config)
 
 	if oCfg.Endpoint == "" {
 		return nil, errors.New("OTLP exporter config requires an Endpoint")
 	}
 
-	e := &exporterImp{}
+	e := &exporter{}
 	e.config = oCfg
 	w, err := newGrpcSender(oCfg)
 	if err != nil {
@@ -61,26 +61,26 @@ func newExporter(cfg config.Exporter) (*exporterImp, error) {
 	return e, nil
 }
 
-func (e *exporterImp) shutdown(context.Context) error {
+func (e *exporter) shutdown(context.Context) error {
 	return e.w.stop()
 }
 
-func (e *exporterImp) pushTraceData(ctx context.Context, td pdata.Traces) error {
+func (e *exporter) pushTraceData(ctx context.Context, td pdata.Traces) error {
 	if err := e.w.exportTrace(ctx, internal.TracesToOtlp(td.InternalRep())); err != nil {
 		return fmt.Errorf("failed to push trace data via OTLP exporter: %w", err)
 	}
 	return nil
 }
 
-func (e *exporterImp) pushMetricsData(ctx context.Context, md pdata.Metrics) error {
+func (e *exporter) pushMetricsData(ctx context.Context, md pdata.Metrics) error {
 	req := internal.MetricsToOtlp(md.InternalRep())
 	if err := e.w.exportMetrics(ctx, req); err != nil {
 		return fmt.Errorf("failed to push metrics data via OTLP exporter: %w", err)
 	}
 	return nil
 }
 
-func (e *exporterImp) pushLogData(ctx context.Context, ld pdata.Logs) error {
+func (e *exporter) pushLogData(ctx context.Context, ld pdata.Logs) error {
 	request := internal.LogsToOtlp(ld.InternalRep())
 	if err := e.w.exportLogs(ctx, request); err != nil {
 		return fmt.Errorf("failed to push log data via OTLP exporter: %w", err)

diff --git a/exporter/otlphttpexporter/otlp.go b/exporter/otlphttpexporter/otlp.go
@@ -39,7 +39,7 @@ import (
 	"go.opentelemetry.io/collector/internal/middleware"
 )
 
-type exporterImp struct {
+type exporter struct {
 	// Input configuration.
 	config     *Config
 	client     *http.Client
@@ -55,7 +55,7 @@ const (
 )
 
 // Crete new exporter.
-func newExporter(cfg config.Exporter, logger *zap.Logger) (*exporterImp, error) {
+func newExporter(cfg config.Exporter, logger *zap.Logger) (*exporter, error) {
 	oCfg := cfg.(*Config)
 
 	if oCfg.Endpoint != "" {
@@ -78,14 +78,14 @@ func newExporter(cfg config.Exporter, logger *zap.Logger) (*exporterImp, error)
 		}
 	}
 
-	return &exporterImp{
+	return &exporter{
 		config: oCfg,
 		client: client,
 		logger: logger,
 	}, nil
 }
 
-func (e *exporterImp) pushTraceData(ctx context.Context, traces pdata.Traces) error {
+func (e *exporter) pushTraceData(ctx context.Context, traces pdata.Traces) error {
 	request, err := traces.ToOtlpProtoBytes()
 	if err != nil {
 		return consumererror.Permanent(err)
@@ -99,7 +99,7 @@ func (e *exporterImp) pushTraceData(ctx context.Context, traces pdata.Traces) er
 	return nil
 }
 
-func (e *exporterImp) pushMetricsData(ctx context.Context, metrics pdata.Metrics) error {
+func (e *exporter) pushMetricsData(ctx context.Context, metrics pdata.Metrics) error {
 	request, err := metrics.ToOtlpProtoBytes()
 	if err != nil {
 		return consumererror.Permanent(err)
@@ -113,7 +113,7 @@ func (e *exporterImp) pushMetricsData(ctx context.Context, metrics pdata.Metrics
 	return nil
 }
 
-func (e *exporterImp) pushLogData(ctx context.Context, logs pdata.Logs) error {
+func (e *exporter) pushLogData(ctx context.Context, logs pdata.Logs) error {
 	request, err := logs.ToOtlpProtoBytes()
 	if err != nil {
 		return consumererror.Permanent(err)
@@ -127,7 +127,7 @@ func (e *exporterImp) pushLogData(ctx context.Context, logs pdata.Logs) error {
 	return nil
 }
 
-func (e *exporterImp) export(ctx context.Context, url string, request []byte) error {
+func (e *exporter) export(ctx context.Context, url string, request []byte) error {
 	e.logger.Debug("Preparing to make HTTP request", zap.String("url", url))
 	req, err := http.NewRequestWithContext(ctx, http.MethodPost, url, bytes.NewReader(request))
 	if err != nil {