Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor "disabled" config flag #181

Conversation

tigrannajaryan
Copy link
Member

We previously had "enabled" config flag which was not honored.
This now implements "disabled" config flag which is honored.

We decided to use "disabled" instead of "enabled" since it is
more common to have enabled items than disabled items in the config
and this reduces litter in the config file.

Github issue: #113

config/configv2.go Show resolved Hide resolved
config/configv2_test.go Show resolved Hide resolved
@pjanotti
Copy link
Contributor

pjanotti commented Jul 19, 2019

Please rebase and fix:

receiver/opencensusreceiver/config_test.go:62:5: unknown field 'Enabled' in struct literal of type configmodels.ReceiverSettings
receiver/opencensusreceiver/config_test.go:83:5: unknown field 'Enabled' in struct literal of type configmodels.ReceiverSettings
receiver/opencensusreceiver/factory_test.go:60:3: unknown field 'Enabled' in struct literal of type configmodels.ReceiverSettings
receiver/opencensusreceiver/factory_test.go:80:6: unknown field 'Enabled' in struct literal of type configmodels.ReceiverSettings
receiver/opencensusreceiver/factory_test.go:123:3: unknown field 'Enabled' in struct literal of type configmodels.ReceiverSettings
receiver/opencensusreceiver/factory_test.go:143:6: unknown field 'Enabled' in struct literal of type configmodels.ReceiverSettings
make: *** [vet] Error 2
The command "make travis-ci" exited with 2.

Tigran Najaryan added 2 commits July 19, 2019 14:55
We previously had "enabled" config flag which was not honored.
This now implements "disabled" config flag which is honored.

We decided to use "disabled" instead of "enabled" since it is
more common to have enabled items than disabled items in the config
and this reduces litter in the config file.

Github issue: open-telemetry#113
@codecov-io
Copy link

Codecov Report

Merging #181 into master will increase coverage by 0.09%.
The diff coverage is 90.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #181      +/-   ##
==========================================
+ Coverage   72.67%   72.77%   +0.09%     
==========================================
  Files         104      104              
  Lines        6039     6090      +51     
==========================================
+ Hits         4389     4432      +43     
- Misses       1425     1433       +8     
  Partials      225      225
Impacted Files Coverage Δ
receiver/opencensusreceiver/factory.go 88.57% <ø> (-0.32%) ⬇️
config/configmodels/configmodels.go 0% <0%> (ø) ⬆️
config/test_helpers.go 50% <100%> (ø) ⬆️
receiver/jaegerreceiver/factory.go 95.83% <100%> (-0.17%) ⬇️
config/configv2.go 98.87% <100%> (+0.22%) ⬆️
service/service.go 68.84% <100%> (ø) ⬆️
receiver/jaegerreceiver/config.go 61.53% <80%> (+11.53%) ⬆️
config/example_factories.go 52.33% <88.88%> (-1.8%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eb96e0...f8d15d1. Read the comment docs.

@tigrannajaryan tigrannajaryan merged commit 7158920 into open-telemetry:master Jul 19, 2019
@tigrannajaryan tigrannajaryan deleted the feature/tigran/disabled-flag branch July 19, 2019 19:09
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Bumped logrus version from v1.8.0 to v1.8.1
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
* Break out collector and operator specific tests

* Fix checkout action

* moved example checking to lint.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants