-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor "disabled" config flag #181
Merged
tigrannajaryan
merged 2 commits into
open-telemetry:master
from
tigrannajaryan:feature/tigran/disabled-flag
Jul 19, 2019
Merged
Honor "disabled" config flag #181
tigrannajaryan
merged 2 commits into
open-telemetry:master
from
tigrannajaryan:feature/tigran/disabled-flag
Jul 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
flands,
pjanotti and
songy23
as code owners
July 19, 2019 18:01
songy23
approved these changes
Jul 19, 2019
pjanotti
approved these changes
Jul 19, 2019
Please rebase and fix:
|
We previously had "enabled" config flag which was not honored. This now implements "disabled" config flag which is honored. We decided to use "disabled" instead of "enabled" since it is more common to have enabled items than disabled items in the config and this reduces litter in the config file. Github issue: open-telemetry#113
tigrannajaryan
force-pushed
the
feature/tigran/disabled-flag
branch
from
July 19, 2019 18:57
8a080f0
to
f8d15d1
Compare
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 72.67% 72.77% +0.09%
==========================================
Files 104 104
Lines 6039 6090 +51
==========================================
+ Hits 4389 4432 +43
- Misses 1425 1433 +8
Partials 225 225
Continue to review full report at Codecov.
|
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Bumped logrus version from v1.8.0 to v1.8.1
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
* Break out collector and operator specific tests * Fix checkout action * moved example checking to lint.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had "enabled" config flag which was not honored.
This now implements "disabled" config flag which is honored.
We decided to use "disabled" instead of "enabled" since it is
more common to have enabled items than disabled items in the config
and this reduces litter in the config file.
Github issue: #113