Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of "disabled" flag in configuration #113

Closed
tigrannajaryan opened this issue Jul 3, 2019 · 1 comment
Closed

Make use of "disabled" flag in configuration #113

tigrannajaryan opened this issue Jul 3, 2019 · 1 comment
Assignees
@tigrannajaryan
Milestone
0.1.0

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Jul 3, 2019 •
edited
Loading

configv2.LoadConfig currently ignores the values of "disabled" flag for all entities. This must be changed. If "disabled=true" the corresponding entity should be unloaded as if it is not present in the configuration and all references from the pipelines to it are also not present.
@tigrannajaryan tigrannajaryan self-assigned this Jul 3, 2019
pjanotti referenced this issue in pjanotti/opentelemetry-service Jul 3, 2019
@songy23
README: fix Stackdriver trace enabling flag (#116)
8a51418 
The README was stale in regards to the Stackdriver
configuration flags in YAML.
This change updates the README to indicate that
the correct flag is `enable_traces` and not `enableTraces`

Fixes #113
Supersedes #114
@tigrannajaryan tigrannajaryan mentioned this issue Jul 16, 2019
Closed
@tigrannajaryan tigrannajaryan added this to the 0.1.0 milestone Jul 18, 2019
@tigrannajaryan tigrannajaryan changed the title Make use of "enabled" flag in configuration Make use of "disabled" flag in configuration Jul 19, 2019
tigrannajaryan pushed a commit that referenced this issue Jul 19, 2019
Honour "disabled" config flag
8ae766f 
We previously had "enabled" config flag which was not honoured.
This now implements "disabled" config flag which is honoured.

We decided to use "disabled" instead of "enabled" since it is
more common to have enabled items than disabled items in the config
and this reduces litter in the config file.

Github issue: #113
tigrannajaryan pushed a commit that referenced this issue Jul 19, 2019
Honour "disabled" config flag
f378503 
We previously had "enabled" config flag which was not honoured.
This now implements "disabled" config flag which is honoured.

We decided to use "disabled" instead of "enabled" since it is
more common to have enabled items than disabled items in the config
and this reduces litter in the config file.

Github issue: #113
tigrannajaryan pushed a commit that referenced this issue Jul 19, 2019
Honour "disabled" config flag
84d82e7 
We previously had "enabled" config flag which was not honoured.
This now implements "disabled" config flag which is honoured.

We decided to use "disabled" instead of "enabled" since it is
more common to have enabled items than disabled items in the config
and this reduces litter in the config file.

Github issue: #113
@tigrannajaryan tigrannajaryan mentioned this issue Jul 19, 2019
Closed
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jul 19, 2019
Honor "disabled" config flag
8a080f0 
We previously had "enabled" config flag which was not honored.
This now implements "disabled" config flag which is honored.

We decided to use "disabled" instead of "enabled" since it is
more common to have enabled items than disabled items in the config
and this reduces litter in the config file.

Github issue: open-telemetry#113
@tigrannajaryan tigrannajaryan mentioned this issue Jul 19, 2019
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jul 19, 2019
Honor "disabled" config flag
1374dcc 
We previously had "enabled" config flag which was not honored.
This now implements "disabled" config flag which is honored.

We decided to use "disabled" instead of "enabled" since it is
more common to have enabled items than disabled items in the config
and this reduces litter in the config file.

Github issue: open-telemetry#113
tigrannajaryan added a commit that referenced this issue Jul 19, 2019
@tigrannajaryan
Honor "disabled" config flag (#181)
7158920 
We previously had "enabled" config flag which was not honored.
This now implements "disabled" config flag which is honored.

We decided to use "disabled" instead of "enabled" since it is
more common to have enabled items than disabled items in the config
and this reduces litter in the config file.

Github issue: #113
@tigrannajaryan
Copy link
Member Author

Done via #181

MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@lizthegrey @rghetia
httptrace calls arrive async/threaded. (open-telemetry#113)
5df3c07
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@erichsueh3
Add --otelcol-image CLI Flag to Operator Helm Chart (open-telemetry…
3eee149 
…#113)

* added default collector image repo and tag values, and added --otelcol-image flag to deployment yaml

* Set default repo and tag values to empty, added conditional for CLI flag to check for empty values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
1 participant
@tigrannajaryan