Move timestamp functions to pdata package #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in open-telemetry#1703
tigrannajaryan
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais and
pjanotti
as code owners
bogdandrutu
approved these changes
Sep 1, 2020
Codecov Report
@@ Coverage Diff @@
## master #1709 +/- ##
==========================================
+ Coverage 92.39% 92.41% +0.02%
==========================================
Files 264 265 +1
Lines 19960 19972 +12
==========================================
+ Hits 18442 18458 +16
+ Misses 1089 1087 -2
+ Partials 429 427 -2
Continue to review full report at Codecov.
|
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Sep 1, 2020
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in open-telemetry#1703
bogdandrutu
pushed a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Sep 1, 2020
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in open-telemetry#1703
bogdandrutu
added a commit
that referenced
this pull request
Sep 1, 2020
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in #1703 Co-authored-by: Tigran Najaryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to prevent circular package dependency that
can arise when we need to hide certain pdata functions in the
internal package in a commit that is coming soon in
#1703