Add StatusCode enum values to avoid usage of the proto generated values #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
requested review from
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
=======================================
Coverage 92.33% 92.34%
=======================================
Files 265 265
Lines 20061 20061
=======================================
+ Hits 18524 18526 +2
+ Misses 1109 1108 -1
+ Partials 428 427 -1
Continue to review full report at Codecov.
|
bogdandrutu
force-pushed
the
spanstatus
branch
from
98e30d8 to
5fbedcb
Compare
This is necessary to prevent circular package dependency that can arise when we need to hide certain pdata functions in the internal package in a commit that is coming soon in open-telemetry#1703
bogdandrutu
force-pushed
the
spanstatus
branch
from
5fbedcb to
569320d
Compare
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
The makeSamplingDecision function is a wrapper around the provider sampler calling ShouldSample with a duplicate configuration struct. That duplication and need for translation as well as the addition function call is unnecessary, this function is called in only one place. Resolves open-telemetry#1706
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will allow contrib to remove dependency on opentelemetry-proto which had the generated proto files.