-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rely on gRPC to batch and loadbalance between connections instead of custom logic #1212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
==========================================
+ Coverage 87.62% 87.73% +0.11%
==========================================
Files 203 203
Lines 14695 14657 -38
==========================================
- Hits 12877 12860 -17
+ Misses 1377 1359 -18
+ Partials 441 438 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make any difference in the performance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, feel free to join after reading the comments.
Yes but only if the data generator from testbed sends concurrent requests (local changed to send 8 concurrent requests) ~20% improvement from 16.4 to 13.1. |
…custom logic Signed-off-by: Bogdan Drutu <[email protected]>
…custom logic (open-telemetry#1212) Signed-off-by: Bogdan Drutu <[email protected]>
…telemetry#1212) * Move propagation package contents to the otel package * Implement package relocation * Update propagation to OTel spec * Add changes to changelog * Add propagation tests
…y#1212) Bumps [boto3](https://github.com/boto/boto3) from 1.20.49 to 1.20.50. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.20.49...1.20.50) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
No description provided.