Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on gRPC to batch and loadbalance between connections instead of custom logic #1212

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

bogdandrutu
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #1212 into master will increase coverage by 0.11%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1212      +/-   ##
==========================================
+ Coverage   87.62%   87.73%   +0.11%     
==========================================
  Files         203      203              
  Lines       14695    14657      -38     
==========================================
- Hits        12877    12860      -17     
+ Misses       1377     1359      -18     
+ Partials      441      438       -3     
Impacted Files Coverage Δ
exporter/otlpexporter/otlp.go 72.15% <93.33%> (+8.90%) ⬆️
translator/internaldata/resource_to_oc.go 83.72% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c448b1c...d8f4143. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make any difference in the performance?

exporter/otlpexporter/otlp.go Outdated Show resolved Hide resolved
Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, feel free to join after reading the comments.

@bogdandrutu
Copy link
Member Author

Does this make any difference in the performance?

Yes but only if the data generator from testbed sends concurrent requests (local changed to send 8 concurrent requests) ~20% improvement from 16.4 to 13.1.

@bogdandrutu bogdandrutu merged commit 8fae9bc into open-telemetry:master Jun 26, 2020
@bogdandrutu bogdandrutu deleted the grpcclient branch June 26, 2020 22:59
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
…telemetry#1212)

* Move propagation package contents to the otel package

* Implement package relocation

* Update propagation to OTel spec

* Add changes to changelog

* Add propagation tests
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
…y#1212)

Bumps [boto3](https://github.com/boto/boto3) from 1.20.49 to 1.20.50.
- [Release notes](https://github.com/boto/boto3/releases)
- [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst)
- [Commits](boto/boto3@1.20.49...1.20.50)

---
updated-dependencies:
- dependency-name: boto3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants