Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default configs for testbed receivers #1214

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Jun 26, 2020

This change plus #1212 and sending 8 concurrent requests from the testbed data generator improved from 16 -> 10 cpu usage.

@codecov
Copy link

codecov bot commented Jun 26, 2020

Codecov Report

Merging #1214 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1214   +/-   ##
=======================================
  Coverage   88.08%   88.08%           
=======================================
  Files         203      203           
  Lines       14649    14649           
=======================================
  Hits        12903    12903           
  Misses       1309     1309           
  Partials      437      437           
Impacted Files Coverage Δ
translator/internaldata/resource_to_oc.go 86.04% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41dc4db...a6ca6b8. Read the comment docs.

Copy link
Member

@tigrannajaryan tigrannajaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume performance improvement is from write buffer size.
The build fails. Please fix, I would like to see the results.

@bogdandrutu bogdandrutu merged commit 12b3d9c into open-telemetry:master Jun 26, 2020
@bogdandrutu bogdandrutu deleted the testbed branch June 26, 2020 23:56
wyTrivail pushed a commit to mxiamxia/opentelemetry-collector that referenced this pull request Jul 13, 2020
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this pull request Nov 11, 2021
* Update codes to match specification

* Add changes to changelog

* go mod tidy

* Add unit tests for codes

* Update SetStatus methods to only filter Unset

* Update apitest code being tested
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this pull request Jul 5, 2024
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this pull request Oct 9, 2024
…y#1214)

* Embed crds

* bumpy

* fix syntax

* add a note

* more notes

* update note

---------

Co-authored-by: Jared Tan <[email protected]>
Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants