[exporter] [chore] Initialize batchSender and queueSender after configuration - #2 #11240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11240 +/- ##
=======================================
Coverage 91.42% 91.42%
=======================================
Files 424 424
Lines 20188 20190 +2
=======================================
+ Hits 18456 18458 +2
Misses 1348 1348
Partials 384 384 ☔ View full report in Codecov by Sentry. |
sfc-gh-sili
force-pushed
the
sili-constructor
branch
2 times, most recently
from
c138ce3
to
05260a1
Compare
sfc-gh-sili
force-pushed
the
sili-constructor
branch
from
05260a1
to
89b2e87
Compare
bogdandrutu
approved these changes
Sep 26, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…guration - #2 (open-telemetry#11240) This PR follows open-telemetry#11041. The previous PR changed the initialization of `batchSender` and `queueSender` to AFTER configuration, because that enables us to access `queueConfig` and `batcherConfig` in the same place. I noticed since then that there is another API for queue configuration, and this PR takes care of that other API #### Link to tracking issue open-telemetry#10368 #### Testing Ran `opentelemetry-collector$ make` to make sure all tests still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #11041.
The previous PR changed the initialization of
batchSenderandqueueSenderto AFTER configuration, because that enables us to accessqueueConfigandbatcherConfigin the same place.I noticed since then that there is another API for queue configuration, and this PR takes care of that other API
Link to tracking issue
#10368
Testing
Ran
opentelemetry-collector$ maketo make sure all tests still pass.