[exporter] [chore] Initialize batchSender and queueSender after configuration - #1 #11041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11041 +/- ##
=======================================
Coverage 92.23% 92.23%
=======================================
Files 406 406
Lines 19101 19108 +7
=======================================
+ Hits 17618 17625 +7
Misses 1123 1123
Partials 360 360 ☔ View full report in Codecov by Sentry. |
sfc-gh-sili
changed the title
mx-psi
approved these changes
Sep 4, 2024
|
Will merge by Friday if there are not further comments |
bogdandrutu
approved these changes
Sep 4, 2024
sfc-gh-sili
changed the title
bogdandrutu
pushed a commit
that referenced
this pull request
Sep 26, 2024
…guration - #2 (#11240) This PR follows #11041. The previous PR changed the initialization of `batchSender` and `queueSender` to AFTER configuration, because that enables us to access `queueConfig` and `batcherConfig` in the same place. I noticed since then that there is another API for queue configuration, and this PR takes care of that other API #### Link to tracking issue #10368 #### Testing Ran `opentelemetry-collector$ make` to make sure all tests still pass.
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
…guration - #2 (open-telemetry#11240) This PR follows open-telemetry#11041. The previous PR changed the initialization of `batchSender` and `queueSender` to AFTER configuration, because that enables us to access `queueConfig` and `batcherConfig` in the same place. I noticed since then that there is another API for queue configuration, and this PR takes care of that other API #### Link to tracking issue open-telemetry#10368 #### Testing Ran `opentelemetry-collector$ make` to make sure all tests still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes initialization of
batchSenderandqueueSenderto AFTER configuration. That way we get to accessqueueConfigandbatcherConfigin the same place.Context: This is some pre-work for changing queue->batch from a pushing model to a pulling model. We will be initialization a
queueBatchSender(queueConfig, batcherConfig)if both queue and batcher are enabled and initializebatchSender(batchConfig)if only batcher is enabled. This change enables us to achieve the goal without changing config API.Link to tracking issue
#10368
Testing
Ran
opentelemetry-collector$ maketo make sure all tests still pass.