Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure that it uses the latest patch release available #206

Merged
merged 1 commit into from
Oct 4, 2022
Merged

make sure that it uses the latest patch release available #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci-goreleaser.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v3
jpkrohling marked this conversation as resolved.
Show resolved Hide resolved
with:
go-version: 1.19.1
go-version: '1.19'
check-latest: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this being bumped by dependabot already when new versions are available? What happens here if there's a 1.20 available?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot does not bump this part, it only bumps the action itself
if 1.20 is out we need to update and push a PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, dependabot will only change that part. When 1.20 is out, will we get build failures, warnings, or things like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, we will still run go1.19 only if we upgrade to go1.20

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review


- name: Generate the sources
run: make generate-sources
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v3
with:
go-version: 1.19.1
go-version: '1.19'
check-latest: true

- name: Verify
run: make ci
3 changes: 2 additions & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v3
with:
go-version: 1.19.1
go-version: '1.19'
check-latest: true

- name: Generate distribution sources
run: make generate-sources
Expand Down