make sure that it uses the latest patch release available #206
Conversation
cpanato
commented
Sep 30, 2022
cpanato
commented
- make sure that it uses the latest patch release available
Signed-off-by: cpanato <[email protected]>
| @@ -35,7 +35,8 @@ jobs: | |||
| - name: Setup Go | |||
| uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: 1.19.1 | |||
| go-version: '1.19' | |||
| check-latest: true | |||
There was a problem hiding this comment.
Isn't this being bumped by dependabot already when new versions are available? What happens here if there's a 1.20 available?
There was a problem hiding this comment.
dependabot does not bump this part, it only bumps the action itself
if 1.20 is out we need to update and push a PR
There was a problem hiding this comment.
Right, dependabot will only change that part. When 1.20 is out, will we get build failures, warnings, or things like that?
There was a problem hiding this comment.
no, we will still run go1.19 only if we upgrade to go1.20
There was a problem hiding this comment.
Thanks for the clarification!
There was a problem hiding this comment.
thanks for the review
| @@ -35,7 +35,8 @@ jobs: | |||
| - name: Setup Go | |||
| uses: actions/setup-go@v3 | |||
| with: | |||
| go-version: 1.19.1 | |||
| go-version: '1.19' | |||
| check-latest: true | |||
There was a problem hiding this comment.
Thanks for the clarification!
