add error checks for elasticsearch exporters

CHANGELOG.md

@@ -137,6 +137,7 @@
 - `datadogexporter`: add error checks for datadog exporter (#9964)
 - `datadogexporter`: Fix host aliases not being properly sent to the Datadog backend (#9748)
 - `groupbyattrsprocessor`: copied aggregationtemporality when grouping metrics. (#9088)
+- `elasticsearchexporter`: add error checks for elasticsearch exporters (#9966)
 - `jaeger`: Update OTLP-Jaeger translation of span events according to the OTel Spec: use `event` log field instead
   of `message` to represent OTel Span Event Name (#10273)
 - `mongodbreceiver`: Fix issue where receiver startup could hang (#10111)

exporter/elasticsearchexporter/exporter.go

@@ -14,7 +14,6 @@
 
 // Package elasticsearchexporter contains an opentelemetry-collector exporter
 // for Elasticsearch.
-// nolint:errcheck
 package elasticsearchexporter // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter"
 
 import (
@@ -145,8 +144,14 @@ func (e *elasticsearchExporter) pushEvent(ctx context.Context, document []byte)
 				zap.NamedError("reason", err))
 
 			attempts++
-			body.Seek(0, io.SeekStart)
-			e.bulkIndexer.Add(ctx, item)
+			if _, seekerr := body.Seek(0, io.SeekStart); seekerr != nil {
+				e.logger.Error("failed to set the next offset.",
+					zap.NamedError("reason", seekerr))
+			}
+			if indexererr := e.bulkIndexer.Add(ctx, item); indexererr != nil {
+				e.logger.Error("failed to add item to indexer.",
+					zap.NamedError("reason", indexererr))
+			}
 
 		case resp.Status == 0 && err != nil:
 			// Encoding error. We didn't even attempt to send the event

exporter/elasticsearchexporter/exporter_test.go

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-// nolint:errcheck
 package elasticsearchexporter
 
 import (
@@ -306,7 +305,9 @@ func newTestExporter(t *testing.T, url string, fns ...func(*Config)) *elasticsea
 	exporter, err := newExporter(zaptest.NewLogger(t), withTestExporterConfig(fns...)(url))
 	require.NoError(t, err)
 
-	t.Cleanup(func() { exporter.Shutdown(context.TODO()) })
+	t.Cleanup(func() {
+		require.NoError(t, exporter.Shutdown(context.TODO()))
+	})
 	return exporter
 }
 

exporter/elasticsearchexporter/internal/objmodel/objmodel.go

@@ -40,7 +40,6 @@
 // Ingest Node is used. But either way, we try to present only well formed
 // document to Elasticsearch.
 
-// nolint:errcheck
 package objmodel // import "github.com/open-telemetry/opentelemetry-collector-contrib/exporter/elasticsearchexporter/internal/objmodel"
 
 import (
@@ -250,17 +249,24 @@ func (doc *Document) iterJSON(v *json.Visitor, dedot bool) error {
 }
 
 func (doc *Document) iterJSONFlat(w *json.Visitor) error {
-	w.OnObjectStart(-1, structform.AnyType)
-	defer w.OnObjectFinished()
+	err := w.OnObjectStart(-1, structform.AnyType)
+	if err != nil {
+		return err
+	}
+	defer func() {
+		err = w.OnObjectFinished()
+	}()
 
 	for i := range doc.fields {
 		fld := &doc.fields[i]
 		if fld.value.IsEmpty() {
 			continue
 		}
 
-		w.OnKey(fld.key)
-		if err := fld.value.iterJSON(w, true); err != nil {
+		if err = w.OnKey(fld.key); err != nil {
+			return err
+		}
+		if err = fld.value.iterJSON(w, true); err != nil {
 			return err
 		}
 	}
@@ -272,8 +278,13 @@ func (doc *Document) iterJSONDedot(w *json.Visitor) error {
 	objPrefix := ""
 	level := 0
 
-	w.OnObjectStart(-1, structform.AnyType)
-	defer w.OnObjectFinished()
+	err := w.OnObjectStart(-1, structform.AnyType)
+	if err != nil {
+		return err
+	}
+	defer func() {
+		err = w.OnObjectFinished()
+	}()
 
 	for i := range doc.fields {
 		fld := &doc.fields[i]
@@ -298,13 +309,17 @@ func (doc *Document) iterJSONDedot(w *json.Visitor) error {
 
 					delta = delta[idx+1:]
 					level--
-					w.OnObjectFinished()
+					if err = w.OnObjectFinished(); err != nil {
+						return err
+					}
 				}
 
 				objPrefix = key[:L]
 			} else { // no common prefix, close all objects we reported so far.
 				for ; level > 0; level-- {
-					w.OnObjectFinished()
+					if err = w.OnObjectFinished(); err != nil {
+						return err
+					}
 				}
 				objPrefix = ""
 			}
@@ -321,19 +336,29 @@ func (doc *Document) iterJSONDedot(w *json.Visitor) error {
 			level++
 			objPrefix = key[:len(objPrefix)+idx+1]
 			fieldName := key[start : start+idx]
-			w.OnKey(fieldName)
-			w.OnObjectStart(-1, structform.AnyType)
+			if err = w.OnKey(fieldName); err != nil {
+				return err
+			}
+			if err = w.OnObjectStart(-1, structform.AnyType); err != nil {
+				return err
+			}
 		}
 
 		// report value
 		fieldName := key[len(objPrefix):]
-		w.OnKey(fieldName)
-		fld.value.iterJSON(w, true)
+		if err = w.OnKey(fieldName); err != nil {
+			return err
+		}
+		if err = fld.value.iterJSON(w, true); err != nil {
+			return err
+		}
 	}
 
 	// close all pending object levels
 	for ; level > 0; level-- {
-		w.OnObjectFinished()
+		if err = w.OnObjectFinished(); err != nil {
+			return err
+		}
 	}
 
 	return nil
@@ -453,13 +478,17 @@ func (v *Value) iterJSON(w *json.Visitor, dedot bool) error {
 		}
 		return v.doc.iterJSON(w, dedot)
 	case KindArr:
-		w.OnArrayStart(-1, structform.AnyType)
+		if err := w.OnArrayStart(-1, structform.AnyType); err != nil {
+			return err
+		}
 		for i := range v.arr {
 			if err := v.arr[i].iterJSON(w, dedot); err != nil {
 				return err
 			}
 		}
-		w.OnArrayFinished()
+		if err := w.OnArrayFinished(); err != nil {
+			return err
+		}
 	}
 
 	return nil