add error checks for elasticsearch exporters

[DiptoChakrabarty]

Description:

adds error check in elasticsearch exporters

Link to tracking Issue: #9749

Testing:

Documentation:

[bogdandrutu]

I prefer this (and everywhere else) to inline this:

if indexererr := e.bulkIndexer.Add(ctx, item); indexererr != nil {
   ...
}

[DiptoChakrabarty]

have done this will push as all improvements suggested are finalised

[bogdandrutu]

Name the return "argument" err and in the defer func do err = w.OnObjectFinished(), then instead of log.Fatal you will actually return an error.

[DiptoChakrabarty]

if this is done the error returned from the defers will trigger the errcheck lint check as the errors returned from the defers are not checked

These are some related issues found
kisielk/errcheck#101
kubernetes-sigs/cluster-api#4586

[bogdandrutu]

I don't think so, can you show me?

func (doc *Document) iterJSONFlat(w *json.Visitor) (err error) {
	err = w.OnObjectStart(-1, structform.AnyType)
	if err != nil {
		return 
	}
	defer func() {
		err = w.OnObjectFinished()
	}()
        ....
}

[DiptoChakrabarty]

done like this

defer func() error {
		err = w.OnObjectFinished()
		if err != nil {
			return err
		}
		return nil
	}()

getting this

[djaglowski]

@DiptoChakrabarty, please take a closer look at Bogdan's example. You cannot return the error from the deferred function, but you can assign the error to a return value on the calling function.

[github-actions]

This PR was marked stale due to lack of activity. It will be closed in 14 days.

[github-actions]

Closed as inactive. Feel free to reopen if this PR is still being worked on.