feat(routingprocessor): route on resource attributes #5694

pmalek-sumo · 2021-10-11T17:59:43Z

Description: Add a feature to routingprocessor to route traces on resource attributes and make it configurable (retaining previous default to read from context).

Link to tracking Issue: Fixes #5538

Testing: Added unit tests.

Documentation: Changed README.

Huge shout-out to @astencel-sumo for this patch! 🙇

jpkrohling

This PR is great! I had only a few minor comments, but overall, this is a great addition and will make the routing processor way more useful than it currently is.

processor/routingprocessor/README.md

processor/routingprocessor/config.go

processor/routingprocessor/routing_test.go

andrzej-stencel · 2021-10-13T13:04:20Z

Fixes #5538

bogdandrutu · 2021-10-13T18:18:00Z

Manually triggered CircleCI.

bogdandrutu · 2021-10-13T18:24:45Z

Lint and unittest failure.

pmalek-sumo · 2021-10-13T20:20:05Z

Lint and unittest failure.

Looks unrelated. I've rebased on HEAD of main.

pmalek-sumo · 2021-10-13T20:35:32Z

Failed UT: 🤷

make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/awsxrayproxy'
go test -race -timeout 300s --tags="" ./...
--- FAIL: TestFactory_CreateExtension (0.00s)
    factory_test.go:71: 
        	Error Trace:	factory_test.go:71
        	Error:      	Received unexpected error:
        	            	Post "http://127.0.0.1:43755/GetSamplingRules": dial tcp 127.0.0.1:43755: connect: connection refused
        	Test:       	TestFactory_CreateExtension
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xff2f1e]

goroutine 7 [running]:
testing.tRunner.func1.2({0x1099860, 0x21ab380})
	/opt/hostedtoolcache/go/1.17.1/x64/src/testing/testing.go:1209 +0x36c
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.17.1/x64/src/testing/testing.go:1212 +0x3b6
panic({0x1099860, 0x21ab380})
	/opt/hostedtoolcache/go/1.17.1/x64/src/runtime/panic.go:1047 +0x266
github.com/open-telemetry/opentelemetry-collector-contrib/extension/awsxrayproxy.TestFactory_CreateExtension(0x0)
	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/extension/awsxrayproxy/factory_test.go:74 +0x79e
testing.tRunner(0xc0002d5ba0, 0x11bbe38)
	/opt/hostedtoolcache/go/1.17.1/x64/src/testing/testing.go:1259 +0x230
created by testing.(*T).Run
	/opt/hostedtoolcache/go/1.17.1/x64/src/testing/testing.go:1306 +0x727
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/extension/awsxrayproxy	0.053s
FAIL
make[2]: *** [../../Makefile.Common:45: test] Error 1
make[1]: *** [Makefile:148: for-all-target-./extension/awsxrayproxy] Error 2

tigrannajaryan · 2021-10-13T20:58:13Z

I file a bug report: #5726

pmalek-sumo · 2021-10-14T14:31:25Z

Rebased and once again it seems there's an unrelated test failure:

make[2]: Entering directory '/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/prometheusreceiver'
go test -race -timeout 300s --tags="" ./...
--- FAIL: TestStartTimeMetricRegex (12.72s)
    metrics_receiver_test.go:1379: 
        	Error Trace:	metrics_receiver_test.go:1379
        	            				metrics_receiver_test.go:1564
        	            				metrics_receiver_test.go:1520
        	Error:      	Not equal: 
        	            	expected: time.Date(1970, time.January, 1, 0, 6, 40, 800000000, time.UTC)
        	            	actual  : time.Date(1970, time.January, 1, 0, 0, 0, 0, time.UTC)
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,4 @@
        	            	 (time.Time) {
        	            	- wall: (uint64) 800000000,
        	            	- ext: (int64) 62135597200,
        	            	+ wall: (uint64) 0,
        	            	+ ext: (int64) 62135596800,
        	            	  loc: (*time.Location)(<nil>)
        	Test:       	TestStartTimeMetricRegex
        	Messages:   	label_values:{value:"400" has_value:true} label_values:{value:"post" has_value:true} points:{timestamp:{seconds:1634220661 nanos:999000000} double_value:nan}
    metrics_receiver_test.go:1379: 
        	Error Trace:	metrics_receiver_test.go:1379
        	            				metrics_receiver_test.go:1564
        	            				metrics_receiver_test.go:1520
        	Error:      	Not equal: 
        	            	expected: time.Date(1970, time.January, 1, 0, 6, 40, 800000000, time.UTC)
        	            	actual  : time.Date(1970, time.January, 1, 0, 0, 0, 0, time.UTC)
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,4 @@
        	            	 (time.Time) {
        	            	- wall: (uint64) 800000000,
        	            	- ext: (int64) 62135597200,
        	            	+ wall: (uint64) 0,
        	            	+ ext: (int64) 62135596800,
        	            	  loc: (*time.Location)(<nil>)
        	Test:       	TestStartTimeMetricRegex
        	Messages:   	label_values:{value:"200" has_value:true} label_values:{value:"post" has_value:true} points:{timestamp:{seconds:1634220661 nanos:999000000} double_value:nan}
    metrics_receiver_test.go:1379: 
        	Error Trace:	metrics_receiver_test.go:1379
        	            				metrics_receiver_test.go:1564
        	            				metrics_receiver_test.go:1520
        	Error:      	Not equal: 
        	            	expected: time.Date(1970, time.January, 1, 0, 6, 40, 800000000, time.UTC)
        	            	actual  : time.Date(1970, time.January, 1, 0, 0, 0, 0, time.UTC)
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,4 @@
        	            	 (time.Time) {
        	            	- wall: (uint64) 800000000,
        	            	- ext: (int64) 62135597200,
        	            	+ wall: (uint64) 0,
        	            	+ ext: (int64) 62135596800,
        	            	  loc: (*time.Location)(<nil>)
        	Test:       	TestStartTimeMetricRegex
        	Messages:   	points:{timestamp:{seconds:1634220661 nanos:999000000} distribution_value:{count:-9223372036854775808 buckets:{count:-9223372036854775808}}}
    metrics_receiver_test.go:1379: 
        	Error Trace:	metrics_receiver_test.go:1379
        	            				metrics_receiver_test.go:1564
        	            				metrics_receiver_test.go:1520
        	Error:      	Not equal: 
        	            	expected: time.Date(1970, time.January, 1, 0, 6, 40, 800000000, time.UTC)
        	            	actual  : time.Date(1970, time.January, 1, 0, 0, 0, 0, time.UTC)
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1,4 +1,4 @@
        	            	 (time.Time) {
        	            	- wall: (uint64) 800000000,
        	            	- ext: (int64) 62135597200,
        	            	+ wall: (uint64) 0,
        	            	+ ext: (int64) 62135596800,
        	            	  loc: (*time.Location)(<nil>)
        	Test:       	TestStartTimeMetricRegex
        	Messages:   	points:{timestamp:{seconds:1634220661 nanos:999000000} summary_value:{count:{value:-9223372036854775808} sum:{} snapshot:{percentile_values:{percentile:1 value:nan}}}}
    metrics_receiver_test.go:1384: 
        	Error Trace:	metrics_receiver_test.go:1384
        	            				metrics_receiver_test.go:1564
        	            				metrics_receiver_test.go:1520
        	Error:      	Not equal: 
        	            	expected: 11
        	            	actual  : 22
        	Test:       	TestStartTimeMetricRegex
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/receiver/prometheusreceiver	38.324s

tigrannajaryan · 2021-10-14T14:43:55Z

Rebased and once again it seems there's an unrelated test failure:

Please file a bug and assign to prometheusreceiver codewners to fix.

pmalek-sumo · 2021-10-14T14:57:45Z

Please file a bug and assign to prometheusreceiver codewners to fix.

Created: #5752

prometheusreceiver doesn't seem to have an entry in CODEOWNERS: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/f89d7a10d861bf584302511f7db463247cdc3fca/.github/CODEOWNERS

bogdandrutu · 2021-10-14T23:10:55Z

Re-triggered manually CircleCi

pmalek-sumo requested a review from jpkrohling as a code owner October 11, 2021 17:59

pmalek-sumo requested a review from a team October 11, 2021 17:59

github-actions bot assigned tigrannajaryan Oct 11, 2021

tigrannajaryan closed this Oct 12, 2021

tigrannajaryan reopened this Oct 12, 2021

jpkrohling reviewed Oct 13, 2021

View reviewed changes

processor/routingprocessor/README.md Outdated Show resolved Hide resolved

processor/routingprocessor/README.md Outdated Show resolved Hide resolved

processor/routingprocessor/config.go Show resolved Hide resolved

processor/routingprocessor/routing_test.go Show resolved Hide resolved

pmalek-sumo force-pushed the routingprocessor-route-on-resource-attribute branch from 0a0579b to 3fb077f Compare October 13, 2021 10:34

pmalek-sumo requested a review from jpkrohling October 13, 2021 10:36

jpkrohling approved these changes Oct 13, 2021

View reviewed changes

jpkrohling added the ready to merge Code review completed; ready to merge by maintainers label Oct 13, 2021

tigrannajaryan closed this Oct 13, 2021

tigrannajaryan reopened this Oct 13, 2021

pmalek-sumo force-pushed the routingprocessor-route-on-resource-attribute branch from 3fb077f to 0bb9559 Compare October 13, 2021 20:19

tigrannajaryan mentioned this pull request Oct 13, 2021

awsxrayproxy: TestFactory_CreateExtension failed #5726

Closed

andrzej-stencel and others added 2 commits October 14, 2021 15:46

feat(routingprocessor): route on resource attributes

c4c7870

Address review comments

52f5f2b

pmalek-sumo force-pushed the routingprocessor-route-on-resource-attribute branch from 0bb9559 to 52f5f2b Compare October 14, 2021 13:46

pmalek-sumo mentioned this pull request Oct 14, 2021

Flaky test: prometheusreceiver: TestStartTimeMetricRegex failing #5752

Closed

tigrannajaryan closed this Oct 14, 2021

tigrannajaryan reopened this Oct 14, 2021

tigrannajaryan merged commit 3bf6a49 into open-telemetry:main Oct 15, 2021

pmalek-sumo mentioned this pull request Jan 3, 2022

Allow to specify resource label as 'from_attribute' in routingprocessor #3746

Closed

sumo-drosiek deleted the routingprocessor-route-on-resource-attribute branch March 1, 2024 14:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(routingprocessor): route on resource attributes #5694

feat(routingprocessor): route on resource attributes #5694

pmalek-sumo commented Oct 11, 2021 •

edited by jpkrohling

Loading

jpkrohling left a comment

andrzej-stencel commented Oct 13, 2021

bogdandrutu commented Oct 13, 2021

bogdandrutu commented Oct 13, 2021

pmalek-sumo commented Oct 13, 2021

pmalek-sumo commented Oct 13, 2021

tigrannajaryan commented Oct 13, 2021

pmalek-sumo commented Oct 14, 2021

tigrannajaryan commented Oct 14, 2021

pmalek-sumo commented Oct 14, 2021

bogdandrutu commented Oct 14, 2021

feat(routingprocessor): route on resource attributes #5694

feat(routingprocessor): route on resource attributes #5694

Conversation

pmalek-sumo commented Oct 11, 2021 • edited by jpkrohling Loading

jpkrohling left a comment

Choose a reason for hiding this comment

andrzej-stencel commented Oct 13, 2021

bogdandrutu commented Oct 13, 2021

bogdandrutu commented Oct 13, 2021

pmalek-sumo commented Oct 13, 2021

pmalek-sumo commented Oct 13, 2021

tigrannajaryan commented Oct 13, 2021

pmalek-sumo commented Oct 14, 2021

tigrannajaryan commented Oct 14, 2021

pmalek-sumo commented Oct 14, 2021

bogdandrutu commented Oct 14, 2021

pmalek-sumo commented Oct 11, 2021 •

edited by jpkrohling

Loading